add Kit support as a independent package #237
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This would be much easier to review without the unrelated formatting changes |
Author
sure let me see what I can do to avoid the formatting changes :) |
Collaborator
|
Also it looks like the LLM made a bunch of unrelated changes to the tests, stuff like |
Author
Let me solve all this to reduce the number of changes 😅 so it's easier to review |
Author
|
@kevinheavey please check the pr again I believe it is in a better place right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From our discussion in telegram you mentioned you prefer having a single package so I replaced solana web3 js with solana kit. I believe this is ready for review :)