Skip to content

Conversation

@ReenigneArcher
Copy link
Member

Description

This PR intends to add tests for the system tray, and depends on #3818

It was originally to be included with 3818, but there are issues with the tests that need to be resolved in the different build environments and it was growing out of hand.

At the time of opening the PR, the tests succeed on Windows, but fail on Linux. Unknown status on macOS due to homebrew builds failing right now.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the test/tray/add-system-tray-tests branch from 5ecfd6d to e2dbaec Compare September 1, 2025 15:38
@codecov
Copy link

codecov bot commented Sep 1, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 12.01%. Comparing base (8bff4d0) to head (d053212).
⚠️ Report is 94 commits behind head on master.

Files with missing lines Patch % Lines
src/system_tray.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4221      +/-   ##
==========================================
+ Coverage   11.34%   12.01%   +0.66%     
==========================================
  Files          92       92              
  Lines       17623    17625       +2     
  Branches     8109     8109              
==========================================
+ Hits         2000     2118     +118     
+ Misses      14917    14611     -306     
- Partials      706      896     +190     
Flag Coverage Δ
Linux-AppImage 12.26% <ø> (+0.70%) ⬆️
Windows-AMD64 12.84% <0.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/system_tray.cpp 61.90% <0.00%> (+61.90%) ⬆️

... and 24 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the test/tray/add-system-tray-tests branch from e2dbaec to 3121286 Compare September 1, 2025 16:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2025

@ReenigneArcher ReenigneArcher force-pushed the test/tray/add-system-tray-tests branch from 3121286 to d053212 Compare September 1, 2025 18:54
@LizardByte-bot
Copy link
Member

It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants