style: linting

Author: lachlangrose

LoopStructural/modelling/core/geological_observations.py

@@ -5,7 +5,7 @@
 that can be attached to geological objects in scenarios.
 """
 
-from typing import Optional, List, Literal, Union
+from typing import Optional, List, Union
 from dataclasses import dataclass, field
 import numpy as np
 import pandas as pd

LoopStructural/modelling/core/geological_scenario.py

@@ -5,7 +5,7 @@
 Provides a fluent interface for defining geological relationships before computational modeling.
 """
 
-from typing import List, Optional, Dict, Union, Any
+from typing import List, Optional, Dict
 import pandas as pd
 import numpy as np
 from ...utils import getLogger

LoopStructural/modelling/core/model_graph.py

@@ -11,12 +11,11 @@
 import numpy as np
 from dataclasses import dataclass, field
 from collections import defaultdict, deque
-import logging
 
 from ...utils import getLogger
 
 if TYPE_CHECKING:
-    from typing import Callable
+    pass
 
 logger = getLogger(__name__)
 
@@ -642,7 +641,7 @@ def topological_sort_by_dependencies(self) -> Dict[str, Union[List[str], List[Li
         deps = self.build_dependency_graph()
 
         # Compute in-degree for Kahn's algorithm
-        indeg: Dict[str, int] = {n: 0 for n in deps.keys()}
+        indeg: Dict[str, int] = dict.fromkeys(deps.keys(), 0)
         for u, succs in deps.items():
             for v in succs:
                 indeg[v] = indeg.get(v, 0) + 1
@@ -1072,7 +1071,7 @@ def _check_for_cycles(self):
 
         # DFS cycle detection with coloring
         WHITE, GRAY, BLACK = 0, 1, 2
-        color = {uid: WHITE for uid in unit_ids}
+        color = dict.fromkeys(unit_ids, WHITE)
 
         def dfs_visit(node_id: str, path: List[str]):
             color[node_id] = GRAY
@@ -1119,7 +1118,7 @@ def _sort_units_within_group(self, units: List[GeologicalObject]) -> List[Geolog
 
         # Build adjacency for relationships within this group
         adj: Dict[str, List[str]] = defaultdict(list)
-        in_degree = {uid: 0 for uid in unit_ids}
+        in_degree = dict.fromkeys(unit_ids, 0)
 
         for unit_id in unit_ids:
             rels = self.graph.get_relationships(from_object_id=unit_id)
@@ -1188,7 +1187,7 @@ def _sort_groups(self, groups: List[List[GeologicalObject]]) -> List[List[Geolog
 
         # Build inter-group adjacency based on unconformity relationships
         group_adj: Dict[int, Set[int]] = defaultdict(set)
-        group_in_degree = {i: 0 for i in range(len(groups))}
+        group_in_degree = dict.fromkeys(range(len(groups)), 0)
 
         unconformity_types = {
             RelationshipType.ERODE_UNCONFORMABLY_OVERLIES,

examples/1_basic/plot_2_surface_modelling.py

@@ -36,7 +36,6 @@
 # model building
 
 from LoopStructural import GeologicalModel
-from LoopStructural.modelling.core.stratigraphic_column import StratigraphicColumn
 from LoopStructural.visualisation import Loop3DView
 from LoopStructural.datasets import load_claudius  # demo data
 

examples/2_fold/plot_2__refolded_folds.py

@@ -6,7 +6,6 @@
 """
 
 from LoopStructural import GeologicalModel
-from LoopStructural.modelling.features import fold
 from LoopStructural.visualisation import Loop3DView, RotationAnglePlotter
 from LoopStructural.datasets import load_laurent2016
 import pandas as pd

examples/5_graph/observations_example.py

@@ -7,7 +7,6 @@
 
 import numpy as np
 from LoopStructural.modelling.core.geological_scenario import GeologicalScenario
-from LoopStructural.modelling.core.geological_observations import ObservationCollection
 
 # ==============================================================================
 # Setup: Model domain
@@ -214,11 +213,11 @@
 
 print(f"\nTotal observations: {len(all_obs)}")
 print(f"Features with observations: {all_obs['feature_name'].unique().tolist()}")
-print(f"\nObservation types:")
+print("\nObservation types:")
 print(all_obs.groupby('feature_name').size())
 
 # Show summary statistics
-print(f"\nSummary:")
+print("\nSummary:")
 print(f"  Contact points (coord=0): {len(all_obs[all_obs['coord'] == 0])}")
 print(f"  Orientation constraints (coord=1): {len(all_obs[all_obs['coord'] == 1])}")
 print(f"  Inequality constraints (coord=2): {len(all_obs[all_obs['coord'] == 2])}")

examples/5_graph/three_tier_example.py

@@ -95,15 +95,15 @@
 # Get conformable groups (separated by unconformities)
 try:
     groups = column_view.identify_conformable_groups()
-    print(f"\nConformable Groups:")
+    print("\nConformable Groups:")
     for i, group in enumerate(groups, 1):
         print(f"  Group {i}: {[u.name for u in group]}")
 except ValueError as e:
     print(f"Error identifying groups: {e}")
 
 # Get unconformities
 unconformities = column_view.get_unconformities()
-print(f"\nUnconformities:")
+print("\nUnconformities:")
 for upper, lower in unconformities:
     upper_obj = model_explicit.topology.get_object(upper)
     lower_obj = model_explicit.topology.get_object(lower)
@@ -217,7 +217,7 @@
 
 # Get stratigraphic information before building
 groups = scenario.get_stratigraphic_groups()
-print(f"\nConformable Groups in Scenario:")
+print("\nConformable Groups in Scenario:")
 for i, group in enumerate(groups, 1):
     print(f"  Group {i}: {group}")
 

tests/unit/test_geological_topology_graph.py

@@ -3,14 +3,11 @@
 """
 
 import pytest
-import numpy as np
 from LoopStructural.modelling.core.model_graph import (
     GeologicalTopologyGraph,
     StratigraphicColumnView,
-    GeologicalObject,
     GeologicalObjectType,
     RelationshipType,
-    TopologicalRelationship,
 )