Skip to content

Commit e538c30

Browse files
committed
0.0.4 bad logic
- memcmp match is 0, not 1
1 parent 29b7d1c commit e538c30

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@ under developement so don't expect stability or anything
88

99
## Version History
1010

11+
12+
### 0.0.4 bad logic
13+
- memcmp match is 0, not 1
14+
15+
### 0.0.3 compress known items

16+
- all known items go on one line
17+
- all unknown items get reported separately
18+
1119
### 0.0.2 Add CRC check
1220
- if OK only print CRC_OK
1321
- if failed show received != calculated

main/main.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ static void uart_event_task(void *pvParameters) {
5656
datacrc=message[msg_len-1]*256+message[msg_len-2]; //swap bytes
5757
msg_crc=calccrc(message,msg_len-2); //calc CRC
5858
if (msg_crc==datacrc) { // compare and proces good CRC
59-
if (memcmp(message, x0f9f_addr, 4)) {x0f9f[0]=message[4];x0f9f[1]=message[5]; break;}
60-
if (memcmp(message, x07cf_addr, 4)) {x07cf[0]=message[4];x07cf[1]=message[5]; break;}
61-
if (memcmp(message, x07da_addr, 4)) {x07da[0]=message[4];x07da[1]=message[5]; break;}
62-
if (memcmp(message, x07df_addr, 4)) {x07df[0]=message[4];x07df[1]=message[5]; break;}
63-
if (memcmp(message, x0833_read, 6)) {break;} //ignore the read request
64-
if (memcmp(message, x0833_resp, 5)) { //dump all known entries
59+
if (!memcmp(message, x0f9f_addr, 4)) {x0f9f[0]=message[4];x0f9f[1]=message[5]; break;}
60+
if (!memcmp(message, x07cf_addr, 4)) {x07cf[0]=message[4];x07cf[1]=message[5]; break;}
61+
if (!memcmp(message, x07da_addr, 4)) {x07da[0]=message[4];x07da[1]=message[5]; break;}
62+
if (!memcmp(message, x07df_addr, 4)) {x07df[0]=message[4];x07df[1]=message[5]; break;}
63+
if (!memcmp(message, x0833_read, 6)) {break;} //ignore the read request
64+
if (!memcmp(message, x0833_resp, 5)) { //dump all known entries
6565
UDPLUS("KNOWN ID ");
6666
for (int i=5;i<msg_len-2;i+=2) UDPLUS("%02x%02x ",message[i],message[i+1]);
6767
UDPLUS("%02x%02x ",x0f9f[0],x0f9f[1]);

version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.0.3
1+
0.0.4

0 commit comments

Comments
 (0)