Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Fail2ban improvements #6

@0xMentorNotAPseudo

Description

@0xMentorNotAPseudo

@d-jorg a little review of this MR:

  • You should rename some file such as fail2ban_class.py .. For example, if we look into your class we clearly see that your managing business logics. Maybe calling your file fail2ban_service.py and your class Fail2banService would be better.

  • you should refactor the logging configuration at level package. We should use per package configuration (or even better a global per project approach).

  • Also, maybe securing your __log_and_dump function would be good (at least handling potential exceptions).

  • Finally, the most important thing: adding both unit and integration tests for fail2ban :-)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingimprovetestUnit and integration test

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions