#20 Validate task files must have .yml extension (#21)

Author: javibravo

lambda_cron/cli/cli_tool.py

@@ -343,14 +343,14 @@ def validate(self):
             if self.cli.task_directory:
                 all_yml_files = [os.path.join(dirpath, f)
                                  for dirpath, dirnames, files in os.walk(self.cli.task_directory)
-                                 for f in files if f.endswith('.yml')]
+                                 for f in files]
                 for file_name in all_yml_files:
+                    if not file_name.endswith('.yml'):
+                        raise RuntimeError('Task is not defined in YAML file (extension .yml): {}'.format(file_name))
                     self.validate_task(schema, file_name)
-        except jsonschema.exceptions.ValidationError, ex:
+        except Exception, ex:
             print("Validation failed! Validation error in task: {}".format(ex.message))
             sys.exit(1)
-        except Exception, ex:
-            raise ex
         print 'Validation success!'
 
     def print_summary(self):

tests/resources/tasks/invalid/invalid_extension.txt

@@ -0,0 +1,8 @@
+name: 'test queue task'
+expression: '0 * * * *'
+task:
+  type: 'queue'
+  QueueName: 'test-queue'
+  MessageBody:
+    message_key_1: 'message_value_1'
+    message_key_2: ['message_value_2']

tests/test_cli_tool.py

@@ -628,3 +628,18 @@ def test_validate_command_directory_error(monkeypatch):
         lambda_cron.run()
 
     assert system_exit.value.code == 1
+
+
+def test_validate_invalid_file_extension(monkeypatch):
+    monkeypatch.setattr(cli_config, 'get_cli_config_file_path', valid_cong_file_path)
+    cli_params = Namespace()
+    cli_params.command = 'validate'
+    cli_params.task_file = get_test_task_path('invalid/invalid_extension.yml')
+    cli_params.task_directory = None
+
+    lambda_cron = LambdaCronCLISpy(cli_params)
+
+    with pytest.raises(SystemExit) as system_exit:
+        lambda_cron.run()
+
+    assert system_exit.value.code == 1