Open
Conversation
Major refactor of the `post_install` logic to improve robustness and registry hygiene: 1. Deterministic Version Detection (Source of Truth): Instead of unreliable directory sniffing, we now parse the official `bin/code` shell script to extract the `VERSIONFOLDER` variable. This is the upstream source of truth for the version hash. 2. Dynamic Registry Template Injection: - Context Menus & Associations: Injected with the resolved hash path (e.g., `$dir\<hash>`). - GitHub Integration: Injected with the root path (`$dir`), as per standard behavior. - Handled via variable replacement in `.reg` templates during runtime. 3. Update-Triggered Registry Cleanup: Implemented a "Clean Slate" policy. During an update (detected by the presence of older version directories matching `^[0-9.]+$`), the script automatically runs uninstall routines for the previous registration. This prevents registry pollution and ensures that HKCU keys strictly correspond to the current installation.
⚡ Risk Assessment —
|
| Files | Summary |
|---|---|
VSCode File Association Iconsbucket/vscode.json |
Corrects file association icon paths in VSCode installer configuration to properly reference icon resources. |
Dig Deeper With Commands
/review <file-path> <function-optional>/chat <file-path> "<question>"/roast <file-path>
Runs only when explicitly triggered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of ScoopInstaller#17196
Summary by MergeMonkey