Feature/cc 434 #75
Closed
Feature/cc 434 #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CC-449 Apply styling from figma to the tomogram select dropdown
seankmartin
commented
Oct 27, 2025
Author
seankmartin
left a comment
seankmartin
left a comment
There was a problem hiding this comment.
some potential places we could improve
frontend/packages/data-portal/app/components/Viewer/ViewerPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/data-portal/app/components/Viewer/ViewerPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/data-portal/app/components/Viewer/ViewerPage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR implements a tomogram selection feature for the neuroglancer viewer, allowing users to switch between different tomograms within a run while preserving viewer state.
Key changes:
- Added tomogram dropdown menu to the viewer interface for selecting different tomograms
- Implemented state management functions to handle tomogram switching with voxel spacing adjustments
- Refactored dropdown components to use a title/subtitle pattern instead of children-only rendering
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/packages/neuroglancer/src/utils.ts | Added dimension type definitions, layer source URL getter, and updated LayerWithSource interface |
| frontend/packages/data-portal/tailwind.config.ts | Added new screen breakpoint for 1800px displays |
| frontend/packages/data-portal/app/routes/view.runs.$id.tsx | Passed tomograms data to ViewerPage component |
| frontend/packages/data-portal/app/components/Viewer/state.ts | Added tomogram switching logic with voxel spacing calculations and layer state management |
| frontend/packages/data-portal/app/components/Viewer/ViewerPage.tsx | Integrated tomogram selection dropdown and refactored all dropdown options to use title prop |
| frontend/packages/data-portal/app/components/Viewer/NeuroglancerDropdown.tsx | Refactored component to accept title/subtitle props instead of rendering children as main content |
| frontend/packages/data-portal/app/components/Viewer/NeuroglancerDropdown.test.tsx | Updated tests to reflect new title/subtitle API |
| frontend/packages/data-portal/app/components/Breadcrumbs.tsx | Adjusted breadcrumb max-width breakpoints for better responsive layout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aranega
approved these changes
Oct 31, 2025
Member
aranega
left a comment
aranega
left a comment
There was a problem hiding this comment.
All looks good :) Thanks @seankmartin ! 🙏
Author
|
Closing as opened on CZI org repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tomogram selection