chore: fix build

coodos · coodos · commit 910ee884aafc · 2026-03-14T12:34:32.000+05:30
diff --git a/infrastructure/eid-wallet/src/lib/services/NotificationService.ts b/infrastructure/eid-wallet/src/lib/services/NotificationService.ts
@@ -1,12 +1,12 @@
 import { PUBLIC_PROVISIONER_URL } from "$env/static/public";
+import { addNotification } from "$lib/stores/notifications";
 import {
     isPermissionGranted,
     registerForPushNotifications,
     requestPermission,
     sendNotification,
 } from "@choochmeque/tauri-plugin-notifications-api";
 import { invoke } from "@tauri-apps/api/core";
-import { addNotification } from "$lib/stores/notifications";
 
 export interface DeviceRegistration {
     eName: string;
@@ -119,12 +119,19 @@ class NotificationService {
      */
     async sendLocalNotification(payload: NotificationPayload): Promise<void> {
         try {
-            // Store notification for the notification panel
-            const data = payload.data as Record<string, string> | undefined;
+            // Store notification for the notification panel — coerce to string values only
+            const data = payload.data
+                ? Object.fromEntries(
+                      Object.entries(payload.data).filter(
+                          (entry): entry is [string, string] =>
+                              typeof entry[1] === "string",
+                      ),
+                  )
+                : undefined;
             addNotification({
                 title: payload.title,
                 body: payload.body,
-                data,
+                data: Object.keys(data ?? {}).length > 0 ? data : undefined,
             });
 
             // Check permissions first
@@ -202,6 +209,8 @@ class NotificationService {
     async checkAndShowNotifications(): Promise<{
         globalMessageId?: string;
         globalChatId?: string;
+        title?: string;
+        body?: string;
     } | null> {
         try {
             console.log("🔍 Checking for notifications from provisioner...");
@@ -273,7 +282,8 @@ class NotificationService {
                         `Found ${data.notifications.length} notification(s)`,
                     );
 
-                    // Show each notification locally
+                    // Show each notification locally — intentionally keep only the
+                    // most recent new_message so the caller navigates to it.
                     let lastMessageNotif: {
                         globalMessageId?: string;
                         globalChatId?: string;
@@ -293,17 +303,15 @@ class NotificationService {
                         }
                     }
                     return lastMessageNotif;
-                } else {
-                    console.log("No new notifications");
-                    return null;
                 }
-            } else {
-                console.log(
-                    "No notifications endpoint available or error:",
-                    response.status,
-                );
+                console.log("No new notifications");
                 return null;
             }
+            console.log(
+                "No notifications endpoint available or error:",
+                response.status,
+            );
+            return null;
         } catch (error) {
             console.error("Error checking notifications:", error);
             return null;
@@ -318,7 +326,7 @@ class NotificationService {
         await this.sendLocalNotification({
             title: "Test Notification",
             body: "This is a test notification from eid-wallet!",
-            data: { test: true, timestamp: new Date().toISOString() },
+            data: { test: "true", timestamp: new Date().toISOString() },
         });
     }
 
diff --git a/infrastructure/eid-wallet/src/lib/stores/notifications.ts b/infrastructure/eid-wallet/src/lib/stores/notifications.ts
@@ -7,17 +7,25 @@ export interface StoredNotification {
 }
 
 const STORAGE_KEY = "eid_wallet_notifications";
+const MAX_NOTIFICATIONS = 200;
+
+let cachedNotifications: StoredNotification[] | null = null;
 
 function loadNotifications(): StoredNotification[] {
+    if (cachedNotifications !== null) return cachedNotifications;
     try {
         const raw = localStorage.getItem(STORAGE_KEY);
-        return raw ? JSON.parse(raw) : [];
+        const parsed: StoredNotification[] = raw ? JSON.parse(raw) : [];
+        cachedNotifications = parsed;
+        return parsed;
     } catch {
-        return [];
+        cachedNotifications = [];
+        return cachedNotifications;
     }
 }
 
 function saveNotifications(notifications: StoredNotification[]): void {
+    cachedNotifications = notifications;
     localStorage.setItem(STORAGE_KEY, JSON.stringify(notifications));
 }
 
@@ -51,7 +59,7 @@ export function addNotification(
         id: crypto.randomUUID(),
         createdAt: new Date().toISOString(),
     });
-    saveNotifications(notifications);
+    saveNotifications(notifications.slice(0, MAX_NOTIFICATIONS));
     notify();
 }
 
diff --git a/infrastructure/eid-wallet/src/routes/(app)/main/+page.svelte b/infrastructure/eid-wallet/src/routes/(app)/main/+page.svelte
@@ -7,6 +7,10 @@ import {
 } from "$env/static/public";
 import { Hero, IdentityCard } from "$lib/fragments";
 import type { GlobalState } from "$lib/global";
+import {
+    getUnreadCount,
+    subscribe as subscribeNotifications,
+} from "$lib/stores/notifications";
 import { BottomSheet, Toast } from "$lib/ui";
 import * as Button from "$lib/ui/Button";
 import { capitalize } from "$lib/utils";
@@ -20,10 +24,6 @@ import { HugeiconsIcon } from "@hugeicons/svelte";
 import axios from "axios";
 import { type Snippet, getContext, onMount } from "svelte";
 import { onDestroy } from "svelte";
-import {
-    getUnreadCount,
-    subscribe as subscribeNotifications,
-} from "$lib/stores/notifications";
 import { Shadow } from "svelte-loading-spinners";
 import QrCode from "svelte-qrcode";
 
@@ -522,7 +522,7 @@ onDestroy(() => {
         </Hero>
 
         <div class="flex items-center gap-2">
-            <Button.Nav href="/notifications" class="relative">
+            <Button.Nav href="/notifications" class="relative" aria-label={notificationCount > 0 ? `Notifications (${notificationCount} unread)` : "Notifications"}>
                 <HugeiconsIcon
                     size={28}
                     strokeWidth={2}
@@ -537,7 +537,7 @@ onDestroy(() => {
                     </span>
                 {/if}
             </Button.Nav>
-            <Button.Nav href="/settings">
+            <Button.Nav href="/settings" aria-label="Settings">
                 <HugeiconsIcon
                     size={32}
                     strokeWidth={2}
diff --git a/infrastructure/eid-wallet/src/routes/(app)/notifications/+page.svelte b/infrastructure/eid-wallet/src/routes/(app)/notifications/+page.svelte
@@ -2,13 +2,13 @@
 import { goto } from "$app/navigation";
 import { AppNav } from "$lib/fragments";
 import {
-    getNotifications,
-    clearNotificationsForChat,
+    type StoredNotification,
     clearAllNotifications,
+    clearNotificationsForChat,
+    getNotifications,
     subscribe,
-    type StoredNotification,
 } from "$lib/stores/notifications";
-import { onMount, onDestroy } from "svelte";
+import { onDestroy, onMount } from "svelte";
 
 let notifications: StoredNotification[] = $state([]);
 let unsubscribe: (() => void) | undefined;
@@ -28,14 +28,17 @@ onDestroy(() => {
 
 function handleNotificationClick(notification: StoredNotification) {
     const data = notification.data;
-    if (data?.type === "new_message" && data.globalMessageId) {
+    if (
+        data?.type === "new_message" &&
+        (data.globalMessageId || data.globalChatId)
+    ) {
+        const messageId = data.globalMessageId || data.globalChatId || "";
+        const chatId = data.globalChatId ?? messageId;
         // Clear all notifications from the same chat
-        if (data.globalChatId) {
-            clearNotificationsForChat(data.globalChatId);
-        }
+        clearNotificationsForChat(chatId);
         // Navigate to open-message page
         goto(
-            `/open-message/${encodeURIComponent(data.globalMessageId)}?chatId=${encodeURIComponent(data.globalChatId || data.globalMessageId)}&title=${encodeURIComponent(notification.title)}&body=${encodeURIComponent(notification.body)}`,
+            `/open-message/${encodeURIComponent(messageId)}?chatId=${encodeURIComponent(chatId)}&title=${encodeURIComponent(notification.title)}&body=${encodeURIComponent(notification.body)}`,
         );
     }
 }
diff --git a/infrastructure/eid-wallet/src/routes/(app)/settings/+page.svelte b/infrastructure/eid-wallet/src/routes/(app)/settings/+page.svelte
@@ -140,14 +140,12 @@ $effect(() => {
             label="Recovery Passphrase"
             href="/settings/passphrase"
         />
-        <!-- svelte-ignore a11y_no_static_element_interactions -->
-        <div onclick={openPrivacy}>
-            <SettingsNavigationBtn
-                icon={Shield01Icon}
-                label="Privacy"
-                href="https://metastate.foundation/"
-            />
-        </div>
+        <SettingsNavigationBtn
+            icon={Shield01Icon}
+            label="Privacy"
+            href="https://metastate.foundation/"
+            onclick={openPrivacy}
+        />
     </div>
     <div>
         <ButtonAction class="mt-5 w-full" callback={showDeleteConfirmation}
diff --git a/infrastructure/eid-wallet/src/routes/(auth)/verify/steps/selfie.svelte b/infrastructure/eid-wallet/src/routes/(auth)/verify/steps/selfie.svelte
@@ -108,7 +108,7 @@ async function captureImage() {
             <div
                 class="relative mt-3 flex flex-col items-center justify-center"
             >
-                <!-- svelte-ignore a11y-media-has-caption -->
+                <!-- svelte-ignore a11y_media_has_caption -->
                 <video
                     bind:this={video}
                     autoplay
diff --git a/infrastructure/eid-wallet/src/routes/(public)/open-message/[globalId]/+page.svelte b/infrastructure/eid-wallet/src/routes/(public)/open-message/[globalId]/+page.svelte
@@ -1,8 +1,8 @@
 <script lang="ts">
 import { page } from "$app/state";
 import {
-    PUBLIC_PICTIQUE_BASE_URL,
     PUBLIC_BLABSY_BASE_URL,
+    PUBLIC_PICTIQUE_BASE_URL,
 } from "$env/static/public";
 
 const globalId = page.params.globalId;
diff --git a/infrastructure/eid-wallet/src/routes/(public)/open-message/[globalId]/+page.ts b/infrastructure/eid-wallet/src/routes/(public)/open-message/[globalId]/+page.ts
@@ -0,0 +1,2 @@
+export const prerender = false;
+export const ssr = false;
diff --git a/infrastructure/eid-wallet/svelte.config.js b/infrastructure/eid-wallet/svelte.config.js
@@ -8,7 +8,9 @@ import { vitePreprocess } from "@sveltejs/vite-plugin-svelte";
 const config = {
     preprocess: vitePreprocess(),
     kit: {
-        adapter: adapter(),
+        adapter: adapter({
+            fallback: "200.html",
+        }),
         env: {
             dir: "../../",
         },
diff --git a/infrastructure/evault-core/src/core/protocol/graphql-server.ts b/infrastructure/evault-core/src/core/protocol/graphql-server.ts
@@ -755,8 +755,8 @@ export class GraphQLServer {
                                     this.deliverWebhooks(
                                         requestingPlatform,
                                         webhookPayload,
-                                    ).catch(() => {
-                                        // Silenced webhook delivery logs
+                                    ).catch((err) => {
+                                        console.error(`[WEBHOOK] Delivery failed for bulk-create envelope ${result.metaEnvelope.id}:`, err);
                                     });
                                 }
 
diff --git a/infrastructure/evault-core/src/services/MessageNotificationService.ts b/infrastructure/evault-core/src/services/MessageNotificationService.ts
@@ -192,7 +192,7 @@ export class MessageNotificationService {
                 const field = rec.get("field");
                 const raw = rec.get("value");
                 const vt = rec.get("valueType");
-                console.log(`[NOTIF] User envelope field "${field}" = ${JSON.stringify(raw)} (type: ${vt})`);
+                console.log(`[NOTIF] User envelope field "${field}" (type: ${vt})`);
                 if (field === "displayName") {
                     return deserializeValue(raw, vt) || null;
                 }
diff --git a/infrastructure/evault-core/src/services/NotificationService.ts b/infrastructure/evault-core/src/services/NotificationService.ts
@@ -101,12 +101,7 @@ export class NotificationService {
     async sendNotificationToEName(eName: string, notification: NotificationPayload): Promise<boolean> {
         const verifications = await this.getDevicesByEName(eName);
 
-        if (verifications.length === 0) {
-            console.log(`[NOTIF] No active devices found for eName: ${eName}`);
-            return false;
-        }
-
-        // Save to DB for in-app polling
+        // Save to DB for in-app polling regardless of device presence
         const notificationEntity = this.notificationRepository.create({
             eName: eName,
             title: notification.title,
@@ -116,6 +111,11 @@ export class NotificationService {
         });
         await this.notificationRepository.save(notificationEntity);
 
+        if (verifications.length === 0) {
+            console.log(`[NOTIF] No active devices found for eName: ${eName}`);
+            return false;
+        }
+
         // Send actual push notification via notification-trigger service
         const triggerUrl = process.env.NOTIFICATION_TRIGGER_URL || `http://localhost:${process.env.NOTIFICATION_TRIGGER_PORT || 3998}`;
         const pushPayload = {
@@ -178,14 +178,14 @@ export class NotificationService {
             console.log(`[NOTIF] Push results for ${eName}: ${pushSucceeded} sent, ${pushFailed} failed`);
             pushResults.forEach((r, i) => {
                 if (r.status === "rejected") {
-                    console.error(`[NOTIF] Push failed for token ${allTokens[i].token.slice(0, 20)}...:`, r.reason);
+                    console.error(`[NOTIF] Push failed for token index ${i}:`, r.reason);
                 }
             });
         } else {
             console.log(`[NOTIF] Push sent successfully to ${pushSucceeded} token(s) for ${eName}`);
         }
 
-        return true;
+        return pushSucceeded > 0 || pushFailed === 0;
     }
 
     async getUndeliveredNotifications(eName: string): Promise<Notification[]> {
diff --git a/platforms/blabsy/client/src/pages/open-message/[globalId].tsx b/platforms/blabsy/client/src/pages/open-message/[globalId].tsx
@@ -8,13 +8,23 @@ export default function OpenMessagePage(): JSX.Element {
     const [loading, setLoading] = useState(true);
 
     useEffect(() => {
-        if (!globalId || typeof globalId !== 'string') return;
+        const id = Array.isArray(globalId) ? globalId[0] : globalId;
+        if (!id || typeof id !== 'string') {
+            setLoading(false);
+            setError('Could not find this conversation.');
+            return;
+        }
 
         const resolve = async (): Promise<void> => {
             try {
                 const baseUrl = process.env.NEXT_PUBLIC_BASE_URL;
+                if (!baseUrl) {
+                    setError('Application configuration error.');
+                    setLoading(false);
+                    return;
+                }
                 const response = await fetch(
-                    `${baseUrl}/api/resolve/${encodeURIComponent(globalId)}`
+                    `${baseUrl}/api/resolve/${encodeURIComponent(id)}`
                 );
 
                 if (!response.ok) {
@@ -25,7 +35,11 @@ export default function OpenMessagePage(): JSX.Element {
 
                 const data = await response.json();
                 if (data.localId) {
-                    await router.replace(`/chat?chatId=${data.localId}`);
+                    await router.replace(
+                        `/chat?chatId=${encodeURIComponent(
+                            String(data.localId)
+                        )}`
+                    );
                 } else {
                     setError('Could not find this conversation.');
                     setLoading(false);
diff --git a/platforms/pictique/client/src/lib/fragments/Header/Header.svelte b/platforms/pictique/client/src/lib/fragments/Header/Header.svelte
@@ -5,16 +5,18 @@
 	import { HugeiconsIcon } from '@hugeicons/svelte';
 	import type { HTMLAttributes } from 'svelte/elements';
 	import { heading as headingStore } from '../../../routes/store';
+	import { onDestroy } from 'svelte';
 
 	const { ...restProps }: HTMLAttributes<HTMLElement> = $props();
 
 	let route = $derived(page.url.pathname);
 	let heading = $state('');
 
 	// Subscribe to the heading store for dynamic titles (e.g. chat names)
-	headingStore.subscribe((value) => {
-		if (value) heading = value;
+	const unsubscribeHeading = headingStore.subscribe((value) => {
+		heading = value;
 	});
+	onDestroy(unsubscribeHeading);
 
 	$effect(() => {
 		if (route.includes('home')) {
diff --git a/platforms/pictique/client/src/routes/open-message/[globalId]/+page.svelte b/platforms/pictique/client/src/routes/open-message/[globalId]/+page.svelte
@@ -22,7 +22,8 @@
 
 			const data = await response.json();
 			if (data.localId) {
-				await goto(`/messages/${data.localId}`);
+				const id = String(data.localId);
+				await goto(`/messages/${encodeURIComponent(id)}`);
 			} else {
 				error = 'Could not find this conversation.';
 				loading = false;

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ async function captureImage() {`
`108`	`108`	`<div`
`109`	`109`	`class="relative mt-3 flex flex-col items-center justify-center"`
`110`	`110`	`>`
`111`		`- <!-- svelte-ignore a11y-media-has-caption -->`
	`111`	`+ <!-- svelte-ignore a11y_media_has_caption -->`
`112`	`112`	`<video`
`113`	`113`	`bind:this={video}`
`114`	`114`	`autoplay`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+export const prerender = false;`
	`2`	`+export const ssr = false;`