Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Fix call to package goal for ci.maven 3.1 release #408

@cherylking

Description

@cherylking

With the 3.1 release of ci.maven, you need to specify runnable in the include parameter once again. No need to specify packageType (defaults to jar when runnable is specified) or outputDirectory (defaults to ${project.build.directory}/liberty-alt-output-dir for package goal and install-feature goal). Change the following code in LibertyRuntime.java:

private void createUberJar() throws MojoExecutionException {
        executeMojo(getPlugin(), goal("package"),
                configuration(element(name("isInstall"), "false"), element(name("include"), "minify"),
                        element(name("outputDirectory"), "target/liberty-alt-output-dir"),
                        element(name("packageType"), "jar"), element(name("serverName"), serverName)),
                env);
    }

to

private void createUberJar() throws MojoExecutionException {
        executeMojo(getPlugin(), goal("package"),
                configuration(element(name("isInstall"), "false"), element(name("include"), "minify,runnable"), element(name("serverName"), serverName)),
                env);
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions