Skip to content

Commit 5d14f86

Browse files
authored
[InfoHud] Fix NPE when joining a world (#269)
What I failed to notice is that when joining a world, the pitch and yaw, which I am constantly reading out in the InfoHud, is null which causes an NPE for one frame. And everytime I get baited that something went wrong, only to find out it's that bug again
2 parents 9979e82 + 7a15e48 commit 5d14f86

File tree

11 files changed

+21
-17
lines changed

11 files changed

+21
-17
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ jobs:
1919
- name: Setup Gradle
2020
uses: gradle/actions/setup-gradle@v4
2121
with:
22-
gradle-version: 8.13
22+
gradle-version: 8.14.3
2323
- name: Build TASmod with Gradle
2424
run: gradle build
2525
- name: Upload Test Report
2626
uses: actions/upload-artifact@v4
27-
if: always()
27+
if: ${{ !cancelled() }}
2828
with:
2929
name: TestResult
3030
path: build/test-results/test/*.xml

.github/workflows/buildandupload.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: Setup Gradle
2626
uses: gradle/actions/setup-gradle@v4
2727
with:
28-
gradle-version: 8.13
28+
gradle-version: 8.14.3
2929
- name: Build TASmod with Gradle
3030
run: gradle build
3131
- name: Upload artifact

.github/workflows/check_formatting.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ jobs:
1919
- name: Setup Gradle
2020
uses: gradle/actions/setup-gradle@v4
2121
with:
22-
gradle-version: 8.13
22+
gradle-version: 8.14.3
2323
- name: Spotless Check
2424
run: gradle spotlessCheck

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- name: Setup Gradle
1818
uses: gradle/actions/setup-gradle@v4
1919
with:
20-
gradle-version: 8.13
20+
gradle-version: 8.14.3
2121
- name: Setup workspace
2222
run: gradle build -Prelease=true
2323
- name: Upload assets

.github/workflows/test_report.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
report:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: dorny/test-reporter@v1.9.1
15+
- uses: dorny/test-reporter@v2
1616
with:
1717
artifact: TestResult
1818
name: TASmod Tests

gradle.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ org.gradle.jvmargs=-Xmx3G
33

44
# Fabric properties
55
minecraft_version=1.12.2
6-
loader_version=0.16.10
7-
loom_version=1.10-SNAPSHOT
6+
loader_version=0.17.2
7+
loom_version=1.11-SNAPSHOT
88

99
# Mod properties
1010
mod_name=Tool-Assisted Speedrun Mod
@@ -16,5 +16,5 @@ mod_email=scribble@minecrafttas.com
1616
# TASmod properties
1717
group=com.minecrafttas
1818
artifact=TASmod-1.12.2
19-
version=Beta1.1
19+
version=Beta1.2
2020
release=false

gradle/wrapper/gradle-wrapper.jar

181 Bytes
Binary file not shown.

gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

gradlew

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ case "$( uname )" in #(
114114
NONSTOP* ) nonstop=true ;;
115115
esac
116116

117-
CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
117+
CLASSPATH="\\\"\\\""
118118

119119

120120
# Determine the Java command to use to start the JVM.
@@ -205,15 +205,15 @@ fi
205205
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
206206

207207
# Collect all arguments for the java command:
208-
# * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,
208+
# * DEFAULT_JVM_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,
209209
# and any embedded shellness will be escaped.
210210
# * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be
211211
# treated as '${Hostname}' itself on the command line.
212212

213213
set -- \
214214
"-Dorg.gradle.appname=$APP_BASE_NAME" \
215215
-classpath "$CLASSPATH" \
216-
org.gradle.wrapper.GradleWrapperMain \
216+
-jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \
217217
"$@"
218218

219219
# Stop when "xargs" is not available.

gradlew.bat

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ goto fail
7070
:execute
7171
@rem Setup the command line
7272

73-
set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
73+
set CLASSPATH=
7474

7575

7676
@rem Execute Gradle
77-
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %*
77+
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %*
7878

7979
:end
8080
@rem End local scope for the variables with windows NT shell

0 commit comments

Comments
 (0)