From a7e8004727238a78604ac452263d41bc55a1b8ea Mon Sep 17 00:00:00 2001 From: Ben Johnson Date: Tue, 5 Aug 2025 11:24:47 -0400 Subject: [PATCH 1/3] cfg.source_model_id -> cfg.source_model.id --- sl/finetuning/services.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sl/finetuning/services.py b/sl/finetuning/services.py index f230ede..e11a13e 100644 --- a/sl/finetuning/services.py +++ b/sl/finetuning/services.py @@ -126,7 +126,7 @@ async def _run_openai_finetuning_job( # Create fine-tuning job client = openai_driver.get_client() oai_job = await client.fine_tuning.jobs.create( - model=cfg.source_model_id, + model=cfg.source_model.id, training_file=file_obj.id, method=Method( type="supervised", From dc3f07bc4d9ee53b72e87a71726fcb89640ce09b Mon Sep 17 00:00:00 2001 From: Ben Johnson Date: Tue, 5 Aug 2025 11:26:29 -0400 Subject: [PATCH 2/3] Update README.md Existing command gives: ``` AssertionError: assert isinstance(ft_job, FTJob) ``` I assume need to change `animal_evaluation` to `ft_job_config` --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8f2e302..8e601ba 100644 --- a/README.md +++ b/README.md @@ -111,7 +111,7 @@ ft_cfg = OpenAIFTJob( ```bash python scripts/run_finetuning_job.py \ --config_module=cfgs/preference_numbers/cfgs.py \ - --cfg_var_name=animal_evaluation \ + --cfg_var_name=ft_job_cfg \ --dataset_path=./data/preference_numbers/owl/filtered_dataset.jsonl \ --output_path=./data/preference_numbers/owl/model.json ``` From 21c2fcc093ee3fef44a9168ea31a6373d72a21b5 Mon Sep 17 00:00:00 2001 From: Ben Johnson Date: Tue, 5 Aug 2025 12:43:33 -0400 Subject: [PATCH 3/3] Update services.py oai_job -> job_status --- sl/finetuning/services.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sl/finetuning/services.py b/sl/finetuning/services.py index e11a13e..3dc442d 100644 --- a/sl/finetuning/services.py +++ b/sl/finetuning/services.py @@ -159,8 +159,8 @@ async def _run_openai_finetuning_job( # Wait before polling again await asyncio.sleep(30) - assert oai_job.fine_tuned_model is not None - return Model(id=oai_job.fine_tuned_model, type="openai") + assert job_status.fine_tuned_model is not None + return Model(id=job_status.fine_tuned_model, type="openai") async def run_finetuning_job(job: FTJob, dataset: list[DatasetRow]) -> Model: