Issue #48 - Made getNamesOfMember return Collection instead of List.

- This allows an implementation to, e.g.., return a set to
improve performance of searching over the collection.

Author: seidewitz

org.modeldriven.alf.fuml.impl/src/org/modeldriven/alf/fuml/impl/uml/NamedElement.java

@@ -9,6 +9,7 @@
 package org.modeldriven.alf.fuml.impl.uml;
 
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.List;
 
 public abstract class NamedElement extends Element implements
@@ -70,8 +71,8 @@ public boolean isDistinguishableFrom(org.modeldriven.alf.uml.NamedElement otherE
             org.modeldriven.alf.uml.Namespace namespace) {
         if (this.getClass().isAssignableFrom(otherElement.getClass()) || 
                 otherElement.getClass().isAssignableFrom(this.getClass())) {
-            List<String> names = namespace.getNamesOfMember(this);
-            names.removeAll(namespace.getNamesOfMember(otherElement));
+            Collection<String> names = namespace.getNamesOfMember(this);
+            names.retainAll(namespace.getNamesOfMember(otherElement));
             return names.isEmpty();
         } else {
             return true;

org.modeldriven.alf/dist/alf-base.jar

@@ -483,7 +483,7 @@ public List<Member> getInheritableMembers() {
         if (this.isClassifier()) {
             Classifier classifier = this.asClassifier();
             for (NamedElement element: classifier.inheritableMembers()) {
-                List<String> names = classifier.getNamesOfMember(element);
+                Collection<String> names = classifier.getNamesOfMember(element);
                 if (names.isEmpty()) {
                     names = Collections.singletonList(element.getName());
                 }

org.modeldriven.alf/src/org/modeldriven/alf/syntax/common/impl/ExternalElementReferenceImpl.java

@@ -116,7 +116,7 @@ protected Collection<Member> deriveMember() {
         List<Member> members = this.getTemplateParameterMembers();
         Namespace umlNamespace = this.getSelf().getUmlNamespace();
         for (NamedElement member: umlNamespace.getMember()) {
-            List<String> names = umlNamespace.getNamesOfMember(member);
+            Collection<String> names = umlNamespace.getNamesOfMember(member);
             if (names.isEmpty()) {
                 members.add(ImportedMemberImpl.makeImportedMember(
                         member.getName(), member, self));

org.modeldriven.alf/src/org/modeldriven/alf/syntax/units/impl/ExternalNamespaceImpl.java

@@ -8,6 +8,7 @@
  *******************************************************************************/
 package org.modeldriven.alf.uml;
 
+import java.util.Collection;
 import java.util.List;
 
 public interface Namespace extends NamedElement {
@@ -25,7 +26,7 @@ public interface Namespace extends NamedElement {
 
 	public List<PackageableElement> getImportedMember();
 
-    public List<String> getNamesOfMember(NamedElement member);
+    public Collection<String> getNamesOfMember(NamedElement member);
 
     public List<NamedElement> resolveInScope(String name, boolean classifierOnly);
 }