From 823fb366b28cbc773d8b4b506bd01978d83422ee Mon Sep 17 00:00:00 2001 From: haosenwang1018 Date: Wed, 25 Feb 2026 04:49:59 +0000 Subject: [PATCH] fix: replace 14 bare excepts with except Exception Bare except catches KeyboardInterrupt and SystemExit, masking real errors. --- sdk/nexent/core/agents/core_agent.py | 2 +- sdk/nexent/core/models/stt_model.py | 12 ++++++------ sdk/nexent/core/tools/terminal_tool.py | 4 ++-- sdk/nexent/core/utils/favicon_extractor.py | 2 +- test/backend/services/test_mcp_container_service.py | 8 ++++---- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/sdk/nexent/core/agents/core_agent.py b/sdk/nexent/core/agents/core_agent.py index d5c5bc975..fb015a661 100644 --- a/sdk/nexent/core/agents/core_agent.py +++ b/sdk/nexent/core/agents/core_agent.py @@ -399,7 +399,7 @@ def __call__(self, task: str, **kwargs): try: self.observer.add_message( self.name, ProcessType.AGENT_FINISH, str(report)) - except: + except Exception: self.observer.add_message(self.name, ProcessType.AGENT_FINISH, "") answer = Template(self.prompt_templates["managed_agent"]["report"], undefined=StrictUndefined).render({ diff --git a/sdk/nexent/core/models/stt_model.py b/sdk/nexent/core/models/stt_model.py index a5656ee35..da97d2850 100644 --- a/sdk/nexent/core/models/stt_model.py +++ b/sdk/nexent/core/models/stt_model.py @@ -503,7 +503,7 @@ async def process_streaming_audio(self, ws_client, segment_size: int): try: await ws_client.send_json({"error": f"STT service error: {str(e)}"}) client_connected = False - except: + except Exception: pass break @@ -515,7 +515,7 @@ async def process_streaming_audio(self, ws_client, segment_size: int): try: result_text = result['payload_msg']['result']['text'] if result['payload_msg']['result'][ 'text'] else "empty" - except: + except Exception: logger.error(f"Malformed result: {result}") logger.info(f"Received response: {result_text}") @@ -550,7 +550,7 @@ async def process_streaming_audio(self, ws_client, segment_size: int): try: await ws_client.send_json({"error": f"STT service connection closed unexpectedly: {e}"}) client_connected = False - except: + except Exception: pass break @@ -572,7 +572,7 @@ async def process_streaming_audio(self, ws_client, segment_size: int): if client_connected: try: await ws_client.send_json({"error": error_msg}) - except: + except Exception: logger.error("Cannot send error message: client disconnected") except websockets.exceptions.WebSocketException as e: @@ -581,7 +581,7 @@ async def process_streaming_audio(self, ws_client, segment_size: int): if client_connected: try: await ws_client.send_json({"error": error_msg}) - except: + except Exception: logger.error("Cannot send error message: client disconnected") except Exception as e: @@ -592,7 +592,7 @@ async def process_streaming_audio(self, ws_client, segment_size: int): if client_connected: try: await ws_client.send_json({"error": error_msg}) - except: + except Exception: logger.error("Cannot send error message: client disconnected") finally: diff --git a/sdk/nexent/core/tools/terminal_tool.py b/sdk/nexent/core/tools/terminal_tool.py index 8b06b646e..796dff8b3 100644 --- a/sdk/nexent/core/tools/terminal_tool.py +++ b/sdk/nexent/core/tools/terminal_tool.py @@ -173,7 +173,7 @@ def _is_session_alive(self, session: Dict[str, Any]) -> bool: return True return False - except: + except Exception: return False def _cleanup_session(self, session: Dict[str, Any]): @@ -187,7 +187,7 @@ def _cleanup_session(self, session: Dict[str, Any]): session["channel"].close() if session and "client" in session: session["client"].close() - except: + except Exception: pass def _clean_output(self, raw_output: str, command: str) -> str: diff --git a/sdk/nexent/core/utils/favicon_extractor.py b/sdk/nexent/core/utils/favicon_extractor.py index 31bbce145..17fe675d8 100644 --- a/sdk/nexent/core/utils/favicon_extractor.py +++ b/sdk/nexent/core/utils/favicon_extractor.py @@ -32,7 +32,7 @@ def check_favicon_exists(url): try: response = requests.head(url, timeout=3, allow_redirects=True) return response.status_code == 200 - except: + except Exception: return False diff --git a/test/backend/services/test_mcp_container_service.py b/test/backend/services/test_mcp_container_service.py index d161a0a58..26f7f0481 100644 --- a/test/backend/services/test_mcp_container_service.py +++ b/test/backend/services/test_mcp_container_service.py @@ -514,7 +514,7 @@ async def test_load_image_from_tar_file_success_with_tags(self, mock_manager): # Clean up try: os.unlink(temp_file_path) - except: + except Exception: pass @pytest.mark.asyncio @@ -540,7 +540,7 @@ async def test_load_image_from_tar_file_success_without_tags(self, mock_manager) # Clean up try: os.unlink(temp_file_path) - except: + except Exception: pass @pytest.mark.asyncio @@ -560,7 +560,7 @@ async def test_load_image_from_tar_file_empty_images(self, mock_manager): # Clean up try: os.unlink(temp_file_path) - except: + except Exception: pass @pytest.mark.asyncio @@ -581,7 +581,7 @@ async def test_load_image_from_tar_file_exception(self, mock_manager): # Clean up try: os.unlink(temp_file_path) - except: + except Exception: pass