Skip to content

Conversation

@mdgeorge4153
Copy link
Contributor

@mdgeorge4153 mdgeorge4153 commented Dec 3, 2025

Description

We now use the same code everywhere to determine the environment to use for package loading/building:

  • check for an explicit environment name
  • try the CLI's active environment name
  • get the chain ID from the cache or the network or the manifest file (using the active CLI env name)
  • try to find a matching environment

This should apply everywhere we invoke the package system on the sui side.

Test plan

shell tests


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • Indexing Framework:

@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sui-docs Ready Ready Preview Comment Dec 6, 2025 1:57pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
multisig-toolkit Ignored Ignored Preview Dec 6, 2025 1:57pm
sui-kiosk Ignored Ignored Preview Dec 6, 2025 1:57pm

@mdgeorge4153 mdgeorge4153 changed the base branch from main to sui-pkg-alt December 3, 2025 00:23
@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Dec 3, 2025
@mdgeorge4153 mdgeorge4153 marked this pull request as ready for review December 3, 2025 01:15
@mdgeorge4153 mdgeorge4153 requested a review from a team as a code owner December 3, 2025 01:15
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env December 3, 2025 01:15 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 requested review from dariorussi, manolisliolios and stefan-mysten and removed request for a team December 3, 2025 01:15
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env December 3, 2025 01:16 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Type: Documentation Improvements or additions to documentation label Dec 3, 2025
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/pkg-alt-find-env branch from ecd63e3 to 868f80e Compare December 5, 2025 21:04
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env December 5, 2025 21:04 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env December 5, 2025 22:47 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env December 5, 2025 23:14 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/pkg-alt-find-env branch from 33da8d5 to cc6c384 Compare December 5, 2025 23:54
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env December 5, 2025 23:54 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/pkg-alt-find-env branch from cc6c384 to 284a91e Compare December 5, 2025 23:56
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env December 5, 2025 23:56 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 enabled auto-merge (rebase) December 5, 2025 23:57
@mdgeorge4153 mdgeorge4153 disabled auto-merge December 6, 2025 13:48
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/pkg-alt-find-env branch from 5bf4dd2 to d8c2dc4 Compare December 6, 2025 13:55
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env December 6, 2025 13:55 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 enabled auto-merge (rebase) December 6, 2025 14:07
@mdgeorge4153 mdgeorge4153 disabled auto-merge December 6, 2025 14:08
@mdgeorge4153 mdgeorge4153 enabled auto-merge (rebase) December 6, 2025 14:08
@mdgeorge4153 mdgeorge4153 merged commit 077c7bb into sui-pkg-alt Dec 6, 2025
55 of 57 checks passed
@mdgeorge4153 mdgeorge4153 deleted the mdgeorge/pkg-alt-find-env branch December 6, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants