Some remarks

[kruisdraad]

Hi there, love the script ... do have some ideas:

• /etc/hosts is not modified to reflect the change made to /etc/hostname
• Add a certbot warning before "please make both txt records with lowest TTL possible. And AFTER creating both check the TXT records, not after each one like certbot suggest as it would break validation due to caching (and then you need to wait the TTL out before retry !)
• force the installation to be run in a screen or tmux :)
• You ask to create DNS records, perhaps do a dig @Label check and spit out a warning that its not working (use dig+trace to bypass local dns)
• Certbot is tricky, perhaps do a self SSL at install and have it do the 'renew' option (which does a new one anyways due to manual renawal) which saves to reinstall stuff all the time with DNS fails on ppl

thnx for making this!

[N3TC4T]

Hey man

Thanks , such good ideas .

will add if I find some free time ,anyway feel free to send pull requests if you wanted to collaborate 👍

[kruisdraad]

ill try, but i am more an ansible guy on this :)