Skip to content

6 detect 10 digit american phone numbers #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
King-Jaden wants to merge 7 commits into
base: main
Choose a base branch
from
Open

6 detect 10 digit american phone numbers #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
520e3c6
Created testing tools for AMERICAN_PHONE_NUMBERS.
King-Jaden Oct 17, 2023
e422261
Improved American phone number detection
King-Jaden Oct 17, 2023
b9e9c0f
Merge branch 'main' into 6-detect-10-digit-american-phone-numbers
King-Jaden Oct 17, 2023
82da39e
Merge remote-tracking branch 'origin/main' into 6-detect-10-digit-ame…
claesmk Oct 18, 2023
dc111c5
Corrected merge issue
claesmk Oct 18, 2023
41aaebf
Merge branch 'main' into 6-detect-10-digit-american-phone-numbers
claesmk Oct 19, 2023
78ca8fa
Merge branch 'main' into 6-detect-10-digit-american-phone-numbers
claesmk Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pii_scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,14 @@ def create_analyzer():
patterns=[student_id_pattern])
registry.add_recognizer(student_id_recognizer)

american_phone_number_pattern = Pattern(name='american_phone_number',
regex=r'(\b)*1(-|.)?(\d{3}|\(\d{3}\))(-|.)?\d{3}(-|.)?\d{4}(\b)*',
score=0.85)
american_phone_number_recognizer = PatternRecognizer(supported_entity='AMERICAN_PHONE_NUMBER',
patterns=[american_phone_number_pattern])
registry.add_recognizer(american_phone_number_recognizer)


# Create a pattern to detect fourteen digit phone numbers
international_pn_pattern = Pattern(name='international_pn',
regex=r'^\d{3}-\d{3}-\d{4}-\d{4}',
Expand Down
4 changes: 2 additions & 2 deletions test_pii_scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ def test_base_supported_entities(self):
'AU_ACN',
'ORGANIZATION',
'STUDENT_ID',
'USERNAME'
]
'USERNAME',
'AMERICAN_PHONE_NUMBER']
for entity in supported_entities:
self.assertIn(entity, results)

Expand Down
29 changes: 28 additions & 1 deletion test_team_superior_coders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class TestSuperiorCoders(unittest.TestCase):
def test_aggie_pride(self):
"""Test to make sure the Aggie Pride function works"""
self.assertEqual('Aggie Pride - Worldwide', show_aggie_pride())

def test_political_standings(self):
""" Test to make sure political standing is detected"""
#positive testcase
Expand Down Expand Up @@ -36,7 +36,34 @@ def test_student_id_detect(self):
print(result)
self.assertNotIn('STUDENT_ID', str(result))

def test_american_phone_number_detect(self):
"""Test to ensure an American Phone Number is detected"""

#positive test case
results = analyze_text('My phone number is 1-(199)-555-9461')
print(results)
self.assertIn('AMERICAN_PHONE_NUMBER', str(results))

#positive test case
results = analyze_text('My phone number is 1.121.555.2962')
print(results)
self.assertIn('AMERICAN_PHONE_NUMBER', str(results))

#positive test case
results = analyze_text('My phone number is 11215552962')
print(results)
self.assertIn('AMERICAN_PHONE_NUMBER', str(results))

#Test to ensure an American Phone Number is not detected
#negetive test case
results = analyze_text('My phone number is -120-555-9461')
print(results)
self.assertNotIn('AMERICAN_PHONE_NUMBER', str(results))

#negetive test case
results = analyze_text('My phone number is 555-9461')
print(results)
self.assertNotIn('AMERICAN_PHONE_NUMBER', str(results))

def test_passport_number_detect(self):
"""Test to show if a passport number is detected"""
Expand Down