Skip to content

Commit 62b748a

Browse files
authored
fix: bump Tapir to fix handling of empty multipart bodies (#785)
1 parent 4f64ae9 commit 62b748a

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

draft-api/src/test/scala/no/ndla/draftapi/controller/FileControllerTest.scala

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import no.ndla.draftapi.{TestData, TestEnvironment, UnitSuite}
1515
import no.ndla.network.tapir.{ErrorHandling, ErrorHelpers, Routes, TapirController}
1616
import no.ndla.tapirtesting.TapirControllerTest
1717
import org.mockito.ArgumentMatchers.any
18-
import org.mockito.Mockito.{reset, when}
18+
import org.mockito.Mockito.{reset, times, verify, when}
1919
import sttp.client3.quick.*
2020

2121
import scala.util.Success
@@ -50,17 +50,17 @@ class FileControllerTest extends UnitSuite with TestEnvironment with TapirContro
5050
CirceUtil.unsafeParseAs[UploadedFileDTO](resp.body) should be(uploaded)
5151
}
5252

53-
// test("That uploading a file fails with 400 if no file is specified") {
54-
// reset(writeService)
55-
// val resp = simpleHttpClient.send(
56-
// quickRequest
57-
// .post(uri"http://localhost:$serverPort/draft-api/v1/files")
58-
// .headers(Map("Authorization" -> TestData.authHeaderWithWriteRole))
59-
// )
60-
//
61-
// resp.code.code should be(400)
62-
// verify(writeService, times(0)).storeFile(any[domain.UploadedFile])
63-
// }
53+
test("That uploading a file fails with 400 if no file is specified") {
54+
reset(writeService)
55+
val resp = simpleHttpClient.send(
56+
quickRequest
57+
.post(uri"http://localhost:$serverPort/draft-api/v1/files")
58+
.headers(Map("Authorization" -> TestData.authHeaderWithWriteRole))
59+
)
60+
61+
resp.code.code should be(400)
62+
verify(writeService, times(0)).storeFile(any[domain.UploadedFile])
63+
}
6464

6565
test("That uploading a file requires publishing rights") {
6666

modules/versions.mill

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ object SharedDependencies {
1414
val CatsEffectV = "3.6.1"
1515
val FlywayV = "11.10.5"
1616
val PostgresV = "42.7.7"
17-
val TapirV = "1.11.47"
17+
val TapirV = "1.11.49"
1818
val ApiSpecV = "0.11.9"
1919
val SttpV = "3.11.0"
2020
val CirceV = "0.14.14"

0 commit comments

Comments
 (0)