fix: fix issue where reporting_entity resulted in key fields being removed from error reports

Author: georgeRobertson

src/dve/core_engine/backends/implementations/duckdb/rules.py

@@ -517,6 +517,7 @@ def notify(self, entities: DuckDBEntities, *, config: Notification) -> Messages:
             messages.append(
                 FeedbackMessage(
                     entity=config.reporting.reporting_entity_override or config.entity_name,
+                    original_entity=config.entity_name,
                     record=record,  # type: ignore
                     error_location=config.reporting.legacy_location,
                     error_message=template_object(config.reporting.message, record),  # type: ignore

src/dve/core_engine/backends/implementations/spark/rules.py

@@ -412,6 +412,7 @@ def notify(self, entities: SparkEntities, *, config: Notification) -> Messages:
                 # more complex extraction done in reporting module
                 FeedbackMessage(
                     entity=config.reporting.reporting_entity_override or config.entity_name,
+                    original_entity=config.entity_name,
                     record=record.asDict(recursive=True),
                     error_location=config.reporting.legacy_location,
                     error_message=template_object(

src/dve/core_engine/message.py

@@ -105,6 +105,8 @@ class FeedbackMessage:  # pylint: disable=too-many-instance-attributes
        still be completed (i.e. filters and joins can still be applied).
 
     """
+    original_entity: Optional[EntityName] = None
+    """The original entity before any modifications to the name (if applicable)."""
     is_informational: bool = False
     """Whether the message is simply for information or has affected the outputs."""
     error_type: Optional[str] = None

src/dve/reporting/utils.py

@@ -26,7 +26,13 @@ def dump_feedback_errors(
     processed = []
 
     for message in messages:
-        primary_keys: list[str] = key_fields.get(message.entity if message.entity else "", [])
+        if message.original_entity is not None:
+            primary_keys = key_fields.get(message.original_entity, [])
+        elif message.entity is not None:
+            primary_keys = key_fields.get(message.entity, [])
+        else:
+            primary_keys = []
+
         error = message.to_dict(
             key_field=primary_keys,
             value_separator=" -- ",