From 2c7054e70cf91ed1abcd00e272d137bb27c2a3cd Mon Sep 17 00:00:00 2001 From: Brian Shand Date: Tue, 21 Oct 2025 23:57:30 +0100 Subject: [PATCH 1/2] Support Ruby 3.4 --- .github/workflows/test.yml | 9 +++++++++ CHANGELOG.md | 3 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d529fce..76e9e6b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -5,18 +5,27 @@ on: [push] jobs: test: strategy: + fail-fast: false matrix: ruby-version: - '3.0' - '3.1' - '3.2' - '3.3' + - '3.4' gemfile: - gemfiles/Gemfile.rails61 - gemfiles/Gemfile.rails70 - gemfiles/Gemfile.rails71 - gemfiles/Gemfile.rails72 exclude: + # rails 6.1 requires ruby < 3.4 + - ruby-version: '3.4' + gemfile: 'gemfiles/Gemfile.rails61' + # rails 7.0 requires ruby >= 2.7, < 3.4 + # https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html + - ruby-version: '3.4' + gemfile: 'gemfiles/Gemfile.rails70' # rails 7.2 requires ruby >= 3.1 # https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html - ruby-version: '3.0' diff --git a/CHANGELOG.md b/CHANGELOG.md index 631618a..fa13081 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## [Unreleased] -* no unreleased changes +### Fixed +* Support Ruby 3.4 ## 2.4.2 / 2025-03-23 * fix link with icon button style From 9e6d15f8226226a5b41a0f4b130e4dad391565ce Mon Sep 17 00:00:00 2001 From: Brian Shand Date: Wed, 22 Oct 2025 15:20:17 +0100 Subject: [PATCH 2/2] Support Ruby 3.4, Rails 8.0 --- .github/workflows/lint.yml | 2 +- .github/workflows/test.yml | 1 + CHANGELOG.md | 2 +- gemfiles/Gemfile.rails80 | 5 +++++ ndr_error.gemspec | 2 +- 5 files changed, 9 insertions(+), 3 deletions(-) create mode 100644 gemfiles/Gemfile.rails80 diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 81c7841..4380a00 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -15,7 +15,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: 3.0 + ruby-version: 3.4 - name: Install dependencies run: bundle install - name: Run RuboCop against BASE..HEAD changes diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 76e9e6b..8c57e01 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,6 +18,7 @@ jobs: - gemfiles/Gemfile.rails70 - gemfiles/Gemfile.rails71 - gemfiles/Gemfile.rails72 + - gemfiles/Gemfile.rails80 exclude: # rails 6.1 requires ruby < 3.4 - ruby-version: '3.4' diff --git a/CHANGELOG.md b/CHANGELOG.md index fa13081..c4e35d4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ ## [Unreleased] ### Fixed -* Support Ruby 3.4 +* Support Ruby 3.4, Rails 8.0 ## 2.4.2 / 2025-03-23 * fix link with icon button style diff --git a/gemfiles/Gemfile.rails80 b/gemfiles/Gemfile.rails80 new file mode 100644 index 0000000..4377f7d --- /dev/null +++ b/gemfiles/Gemfile.rails80 @@ -0,0 +1,5 @@ +source 'https://rubygems.org' + +gemspec path: '..' + +gem 'rails', '~> 8.0.0' diff --git a/ndr_error.gemspec b/ndr_error.gemspec index b50b5b5..ecc62c2 100644 --- a/ndr_error.gemspec +++ b/ndr_error.gemspec @@ -21,7 +21,7 @@ Gem::Specification.new do |s| s.required_ruby_version = '>= 3.0' - s.add_dependency 'rails', '>= 6.1', '< 7.3' + s.add_dependency 'rails', '>= 6.1', '< 8.1' # Support rails 6.1 with Ruby 3.1 s.add_dependency 'net-imap'