Skip to content

Commit 0a95771

Browse files
authored
Restrict treetop gem dependency (#9)
Fix concurrent-ruby version to 1.3.4 for older Rails versions
1 parent 507fc80 commit 0a95771

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## [Unreleased]
2-
* no unreleased changes *
2+
### Fixed
3+
* Restrict treetop gem dependency
34

45
## 1.1.2 / 2024-11-18
56
### Fixed

gemfiles/Gemfile.rails70

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,6 @@ source 'https://rubygems.org'
33
gemspec path: '..'
44

55
gem 'rails', '~> 7.0.0'
6+
7+
# Latest concurrent-ruby breaks Rails < 7.1. See https://github.com/rails/rails/issues/54260
8+
gem 'concurrent-ruby', '1.3.4'

tnql.gemspec

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ lib = File.expand_path('lib', __dir__)
22
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
33
require 'tnql/version'
44

5+
# We list development dependencies for all Rails versions here.
6+
# Rails version-specific dependencies can go in the relevant Gemfile.
7+
# rubocop:disable Gemspec/DevelopmentDependencies
58
Gem::Specification.new do |spec|
69
spec.name = 'tnql'
710
spec.version = Tnql::VERSION
@@ -26,7 +29,9 @@ Gem::Specification.new do |spec|
2629
spec.add_dependency 'activesupport', '>= 7.0', '< 8.1'
2730
spec.add_dependency 'chronic', '~> 0.3'
2831
spec.add_dependency 'ndr_support', '>= 3.0', '< 6'
29-
spec.add_dependency 'treetop', '>= 1.4.10'
32+
# treetop 1.6.14 causes errors. I think this may be a buggy release and fixed soon,
33+
# but I'll restrict the version we use for now.
34+
spec.add_dependency 'treetop', '~> 1.6.12', '< 1.6.14'
3035

3136
spec.add_development_dependency 'bundler'
3237
spec.add_development_dependency 'guard'
@@ -38,3 +43,4 @@ Gem::Specification.new do |spec|
3843
spec.add_development_dependency 'rake'
3944
spec.add_development_dependency 'terminal-notifier-guard' if RUBY_PLATFORM =~ /darwin/
4045
end
46+
# rubocop:enable Gemspec/DevelopmentDependencies

0 commit comments

Comments
 (0)