Skip to content

Forced load imbalance#3380

Open
nanz-nv wants to merge 1 commit intoNVIDIA:mainfrom
nanz-nv:nanz/load_balance_for_main
Open

Forced load imbalance#3380
nanz-nv wants to merge 1 commit intoNVIDIA:mainfrom
nanz-nv:nanz/load_balance_for_main

Conversation

@nanz-nv
Copy link

@nanz-nv nanz-nv commented Feb 12, 2026

What does this PR do ?

This PR tries to add a utility to force load imbalance among experts. dev PR #2917

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@nanz-nv nanz-nv requested review from a team as code owners February 12, 2026 06:41
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 12, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g ko3n1g requested a review from a team February 12, 2026 06:42
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Feb 14, 2026
@Phlip79 Phlip79 added Expert Review Apply this label to indicate that your PR is ready for expert review. complexity: low labels Feb 17, 2026
@Phlip79
Copy link
Member

Phlip79 commented Feb 17, 2026

/ok to test c96049d

@Phlip79
Copy link
Member

Phlip79 commented Feb 17, 2026

@nanz-nv please fix test error

"""[Experimental] Force load balancing with random logits for MoE router, supports naive topk
and group-limited topk. This is an experimental feature and only for benchmark."""

moe_router_force_biased: Optional[float] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits;

  1. could we make this more explicit in the naming - moe_router_expert_bias_force_random
  2. curious why this is experimental

@yanring yanring requested a review from Victarry February 25, 2026 00:27
Co-authored-by: Dennis(Zhenhuan) Liu <denliu@nvidia.com>
@Victarry Victarry force-pushed the nanz/load_balance_for_main branch from c96049d to 9ff4db8 Compare March 3, 2026 06:01
@Victarry
Copy link
Contributor

Victarry commented Mar 3, 2026

/ok to test 9ff4db8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request complexity: low Expert Review Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants