Enable sharding for Zarr files for external aerodynamics pipeline#41
Merged
saikrishnanc-nv merged 4 commits intoNVIDIA:mainfrom Dec 3, 2025
Merged
Conversation
Contributor
Author
|
/blossom-ci |
coreyjadams
approved these changes
Dec 3, 2025
Collaborator
coreyjadams
left a comment
There was a problem hiding this comment.
Looks good to me! I have an IO benchmarking script for DrivaerML, we could do some performance tests on the sharding configuration if you want. But it's impossible to hit it perfectly in all cases. Since chunk size and chunks per shard is configurable, these are good defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables sharding, for Zarr files produced by the external aerodynamics pipeline.
This follows Zarr docs, and roughly creates ~1 GB shards, each of which contain ~1000 chunks each of which are ~1 MB in size.
This is being done to reduce number of files for large files (volume files for example), while maintaining fast random access (because of chunking).
Tests are also being added.