fix: unit tests

Author: NathanWalker

apps/nativescript-demo-ng/src/tests/spans.spec.ts

@@ -106,25 +106,25 @@ describe('Spans', () => {
         expect(textBase.formattedText.spans.getItem(1).text).toBe('1');
         expect(textBase.formattedText.spans.getItem(2).text).toBe('2');
       });
-      it('correctly adds dynamically', async () => {
+      it('correctly adds dynamically when show is true', () => {
         const fixture = TestBed.createComponent(DynamicSpansComponent);
-        const textBase = fixture.componentInstance.textBase.nativeElement;
+        // default show = true
         fixture.detectChanges();
+        const textBase = fixture.componentInstance.textBase.nativeElement;
         expect(textBase.formattedText.spans.length).toBe(3);
         expect(textBase.formattedText.spans.getItem(0).text).toBe('0');
         expect(textBase.formattedText.spans.getItem(1).text).toBe('1');
         expect(textBase.formattedText.spans.getItem(2).text).toBe('2');
+      });
+
+      it('correctly adds dynamically when show is false', () => {
+        const fixture = TestBed.createComponent(DynamicSpansComponent);
         fixture.componentInstance.show = false;
         fixture.detectChanges();
+        const textBase = fixture.componentInstance.textBase.nativeElement;
         expect(textBase.formattedText.spans.length).toBe(2);
         expect(textBase.formattedText.spans.getItem(0).text).toBe('0');
         expect(textBase.formattedText.spans.getItem(1).text).toBe('2');
-        fixture.componentInstance.show = true;
-        fixture.detectChanges();
-        expect(textBase.formattedText.spans.length).toBe(3);
-        expect(textBase.formattedText.spans.getItem(0).text).toBe('0');
-        expect(textBase.formattedText.spans.getItem(1).text).toBe('1');
-        expect(textBase.formattedText.spans.getItem(2).text).toBe('2');
       });
 
       it('correctly adds FormattedString', async () => {
@@ -137,25 +137,25 @@ describe('Spans', () => {
         expect(textBase.formattedText.spans.getItem(2).text).toBe('2');
       });
 
-      it('correctly adds FormattedString dynamically', async () => {
+      it('correctly adds FormattedString dynamically when show is true', () => {
         const fixture = TestBed.createComponent(DynamicFormattedStringComponent);
-        const textBase = fixture.componentInstance.textBase.nativeElement;
+        // default show = true
         fixture.detectChanges();
+        const textBase = fixture.componentInstance.textBase.nativeElement;
         expect(textBase.formattedText.spans.length).toBe(3);
         expect(textBase.formattedText.spans.getItem(0).text).toBe('0');
         expect(textBase.formattedText.spans.getItem(1).text).toBe('1');
         expect(textBase.formattedText.spans.getItem(2).text).toBe('2');
+      });
+
+      it('correctly adds FormattedString dynamically when show is false', () => {
+        const fixture = TestBed.createComponent(DynamicFormattedStringComponent);
         fixture.componentInstance.show = false;
         fixture.detectChanges();
+        const textBase = fixture.componentInstance.textBase.nativeElement;
         expect(textBase.formattedText.spans.length).toBe(2);
         expect(textBase.formattedText.spans.getItem(0).text).toBe('0');
         expect(textBase.formattedText.spans.getItem(1).text).toBe('2');
-        fixture.componentInstance.show = true;
-        fixture.detectChanges();
-        expect(textBase.formattedText.spans.length).toBe(3);
-        expect(textBase.formattedText.spans.getItem(0).text).toBe('0');
-        expect(textBase.formattedText.spans.getItem(1).text).toBe('1');
-        expect(textBase.formattedText.spans.getItem(2).text).toBe('2');
       });
     });
   }

apps/nativescript-demo-ng/src/tests/textnode.spec.ts

@@ -31,23 +31,33 @@ describe('TextNode', () => {
     const textNode = new TextNode('foo');
     expect(textNode.text).toBe('foo');
   });
-  it('should set text to Label', () => {
+  it('should set initial text to Label', () => {
     const fixture = TestBed.createComponent(TextNodeComponent);
     fixture.detectChanges();
     const label = fixture.componentInstance.textElement.nativeElement;
     expect(label.text).toBe('textnode');
+  });
+
+  it('should clear Label text for null value', () => {
+    const fixture = TestBed.createComponent(TextNodeComponent);
     fixture.componentInstance.text = null;
     fixture.detectChanges();
+    const label = fixture.componentInstance.textElement.nativeElement;
     expect(label.text).toBe('');
   });
 
-  it('should set text to Label with Spans', () => {
+  it('should set initial text to Label with Spans', () => {
     const fixture = TestBed.createComponent(TextNodeSpansComponent);
     fixture.detectChanges();
     const label = fixture.componentInstance.textElement.nativeElement;
     expect(label.text).toBe('textnode');
+  });
+
+  it('should clear Label text with Spans for null value', () => {
+    const fixture = TestBed.createComponent(TextNodeSpansComponent);
     fixture.componentInstance.text = null;
     fixture.detectChanges();
+    const label = fixture.componentInstance.textElement.nativeElement;
     expect(label.text).toBe('');
   });
 });