Skip to content

Nxd 24 - Show Error Reason When Uploading A Resume #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taljacob2 merged 4 commits into from
Jun 2, 2025
Merged

Nxd 24 - Show Error Reason When Uploading A Resume #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a522d2
Update Resume Resource Errors: Surround Error Responses With Message …
taljacob2 Jun 2, 2025
01c6bbd
Update Resume Resource 400 Errors In Swagger: Surround Error Response…
taljacob2 Jun 2, 2025
8b5bac9
Show Resume Validation Bad Request Errors In Resume Page
taljacob2 Jun 2, 2025
6953604
Update Resource Resumes Tests With New Error Schema
taljacob2 Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nextstep-backend/src/controllers/resources_controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const createResumeResource = async (req: Request, res: Response) => {
return res.status(201).send(resumeFilename);
} catch (error) {
if (error instanceof multer.MulterError || error instanceof TypeError) {
return res.status(400).send(error.message);
return res.status(400).send({ message: error.message });
} else {
handleError(error, res);
}
Expand Down
18 changes: 14 additions & 4 deletions nextstep-backend/src/openapi/swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,14 +816,24 @@ paths:
'400':
description: Bad request
content:
text/plain:
application/json:
schema:
type: object
properties:
message:
type: string
description: Error message indicating the specific issue
example: "File too large"
examples:
fileTooLarge:
value: "File too large"
value:
message: "File too large"
invalidFileType:
value: "Invalid file type. Only PDF, DOC, DOCX and TXT/TEXT files are allowed"
value:
message: "Invalid file type. Only PDF, DOC, DOCX and TXT/TEXT files are allowed"
noFileUploaded:
value: "No file uploaded"
value:
message: "No file uploaded"
'401':
description: Unauthorized
'500':
Expand Down
4 changes: 2 additions & 2 deletions nextstep-backend/src/tests/resources_resumes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ describe('Resume API Tests', () => {
.attach('file', Buffer.from('invalid content'), { filename: 'test.png' })
.expect(400);

expect(response.text).toBe('Invalid file type. Only PDF, DOC, DOCX and TXT/TEXT files are allowed.');
expect(response.text).toBe(`{"message":"Invalid file type. Only PDF, DOC, DOCX and TXT/TEXT files are allowed."}`);
});

it('should handle missing file', async () => {
Expand All @@ -152,7 +152,7 @@ describe('Resume API Tests', () => {
.set('Authorization', `Bearer ${testToken}`)
.expect(400);

expect(response.text).toBe('No file uploaded.');
expect(response.text).toBe(`{"message":"No file uploaded."}`);
});
});

Expand Down
10 changes: 8 additions & 2 deletions nextstep-frontend/src/pages/Resume.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,14 @@ const Resume: React.FC = () => {
setLoading(false);
};

} catch (err) {
setError(err instanceof Error ? err.message : 'An error occurred');
} catch (err: any) {
if (err.response && err.response.status === 400 &&
err.response.data && err.response.data &&
err.response.data.message) {
setError(err.response.data.message);
} else {
setError(err instanceof Error ? err.message : 'An error occurred');
}
setLoading(false);
}
};
Expand Down
Loading