Skip to content

Commit 0219306

Browse files
committed
conductor: archive s3-head-preview_20260311 track
- Elevated 6 patterns to patterns.md (Result type alias, highlight_content_from_string, shell pipe streaming, in-memory binary detection, S3 head state management, config test pattern) - Moved track to conductor/archive/ - Updated tracks.md with archive comment
1 parent d150aff commit 0219306

6 files changed

Lines changed: 9 additions & 3 deletions

File tree

conductor/tracks/s3-head-preview_20260311/learnings.md renamed to conductor/archive/s3-head-preview_20260311/learnings.md

File renamed without changes.

conductor/tracks/s3-head-preview_20260311/metadata.json renamed to conductor/archive/s3-head-preview_20260311/metadata.json

File renamed without changes.
File renamed without changes.
File renamed without changes.

conductor/patterns.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,4 +176,11 @@ This file is the project's institutional knowledge - learnings extracted from co
176176
- `wrap_text()` char-boundary string wrapping for long URIs/paths in preview panels — splits at char boundaries (not word boundaries) since URIs have no natural breaks; uses `preview_area.width` for dynamic wrap width (from: S3 preview fix 9efcdb5, 2026-03-10)
177177
- `Y` key in `handle_preview_keys` for clipboard copy — mirrors tree-panel `y` behavior for consistent UX across panels (from: S3 preview fix 9efcdb5, 2026-03-10)
178178

179-
Last refreshed: 2026-03-11 (S3 preview URI-wrapping and Y-key patterns added)
179+
- Use `std::result::Result<T, E>` explicitly when the crate has a custom `Result<T>` type alias — avoids confusing type inference errors (from: s3-head-preview_20260311, archived 2026-03-11)
180+
- `highlight_content_from_string()` reuses `detect_syntax_name` + `highlight_single_line` for in-memory content — same pipeline as file-based highlighting (from: s3-head-preview_20260311, archived 2026-03-11)
181+
- Shell pipe via `sh -c 'aws s3 cp ... - | head -n N'` is cleanest way to stream first N lines without downloading full file (from: s3-head-preview_20260311, archived 2026-03-11)
182+
- Binary detection for in-memory content needs `content.as_bytes()[..check_len].contains(&0)` — same pattern as file-based binary check (from: s3-head-preview_20260311, archived 2026-03-11)
183+
- S3 head state (active/loading/content/uri) lives on App struct alongside s3_backend/s3_config — reset on file navigation change in update_preview() (from: s3-head-preview_20260311, archived 2026-03-11)
184+
- Config test pattern: default → TOML parse → merge → CLI load with explicit path (from: s3-head-preview_20260311, archived 2026-03-11)
185+
186+
Last refreshed: 2026-03-11 (S3 head preview patterns elevated)

conductor/tracks.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,5 +68,4 @@
6868

6969
---
7070

71-
## [x] Track: S3 Head Preview — Stream first N lines of S3 files in preview panel
72-
*Link: [./conductor/tracks/s3-head-preview_20260311/](./conductor/tracks/s3-head-preview_20260311/)*
71+
<!-- Archived: s3-head-preview_20260311 (2026-03-11) → conductor/archive/ -->

0 commit comments

Comments
 (0)