JSON Impl and schema for BuildResult #14426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress on NixOS#13405, which asks for an explicit characterisation of the equivalence relation like the one given here. Also progress on NixOS#11895, because we're using the term "build trace entry" instead of "realisation". Mention NixOS#9259, a future work item. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
Note, starting to make progress on NixOS#11895 by calling it this in the manual.
|
FWIW Determinate Nix also has a JSON serialization for One difference is that the status strings follow the enum values, i.e. |
|
That looks like the only difference? I'm happy to go back to camel case. I had a similar feeling after I did it that way too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
More JSON!
CC @mschwaig @edef1c it occurs to me that perhaps
BuildResultwas (at least closer to) the type for build trace values we wanted all along. E.g. being able to sign build failures is cool, and if we move the signature here, we also sign for all the outputs at once as @mschwaig wanted.Context
Depends on #14425
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.