Better JSON schema for derivation outputs #14427
Open
+163
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now uses a `oneOf` and properly models each type of output (corresponding to each type of derivation) separately.
xokdvium
reviewed
Oct 31, 2025
Comment on lines
+162
to
+166
| - "$ref": "#/$defs/output/inputAddressed" | ||
| - "$ref": "#/$defs/output/caFixed" | ||
| - "$ref": "#/$defs/output/caFloating" | ||
| - "$ref": "#/$defs/output/deferred" | ||
| - "$ref": "#/$defs/output/impure" |
There was a problem hiding this comment.
This doesn't get rendered correctly in the book. Is that supposed to be this way?
There was a problem hiding this comment.
Good point, I'll take a look.
There was a problem hiding this comment.
Hmmm, Actually it looks fine to me. What am I missing?
There are some table entries like
Defined in
#/$defs/output/overall"
and I was trying to sed them away before, but TBH now I feel like it is isn't worth it, at least for intra-schema references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It now uses a
oneOfand properly models each type of output (corresponding to each type of derivation) separately.Context
The actual format is the same as before. Just the schema has been made more accurate.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.