Assign average output values for parent cells #955
+254
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritorto
added
the
manual:irrelevant
Member
Author
|
jenkins build this opm-simulators=6642 serial please |
aritorto
changed the title
aritorto
force-pushed
the
averageVanishedCells
branch
3 times, most recently
from
bc40dd0 to
e5d17b6
Compare
Member
Author
|
jenkins build this serial please |
Member
Author
|
jenkins build this opm-simulators=6642 serial please |
Member
Author
|
jenkins build this serial please |
Member
Author
|
jenkins build this opm-simulators=6642 serial nompi please |
1 similar comment
Member
Author
|
jenkins build this opm-simulators=6642 serial nompi please |
Member
Author
|
jenkins build this opm-simulators=6642 serial please |
Member
Author
|
jenkins build this opm-simulators=6642 serial please |
aritorto
force-pushed
the
averageVanishedCells
branch
2 times, most recently
from
9e39aad to
dcc659f
Compare
Member
Author
|
jenkins build this opm-simulators=6642 serial please |
aritorto
force-pushed
the
averageVanishedCells
branch
from
dcc659f to
49420f8
Compare
Member
Author
|
jenkins build this opm-simulators=6642 serial please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #945, which introduced a method for extracting data::Solution and restart values from the leaf grid back to the level grids. In that implementation, cells that disappeared during refinement (i.e., parent cells) were assigned “rubbish” values.
This PR replaces those "rubbish" values with the average of the corresponding children’s data. At the moment, all named data fields are handled using this averaging approach. In future work, we plan to refine this behavior for specific field properties that may require different aggregation methods.