improving water=fishpond tags

[govvin]

I created a MapRoulette (and a chance to play with the TagFix configuration) to review geometries tagged as water=fishpond and propose tags to improve consistency. The tasks set is limited to closed ways with the water=fishpond tag.

The separate tagging of the physical feature (natural=water + water=pond) is made distinct from the cultivation/farming (landuse=aquaculture + aquaculture=fish), whereas the original implied both with [water=fishpond](https://taginfo.geofabrik.de/asia/philippines/tags/water=fishpond).

This is a beginner-friendly challenge, where it's possible for a contributor to review a task, then answer Yes/No to apply the proposed tags (or edit the tags), without leaving MR.

If the issue is not apparent from the imagery, or the contributor wants to have a closer look, they may opt to use an editor (the proposed tag changes works correctly in JOSM, but iD will only show the original) for a closer review of the task.  

The challenge is online, but not (yet) publicly discoverable, in case anyone here has questions, or other concerns with the objective, or the approach (TagFix).

Feel free to test the challenge and share your thoughts here, or directly through within the MR challenge's task comments.

Adding this to the repo, for reference in future workflows involving tag fixes (especially if they're only that.)

[Timmy-Tesseract]

It seems likely that the mappers that added water=fishpond did not differentiate fishponds from ponds containing shrimp. For this reason I think it would be preferable to only add landuse=aquaculture but no aquaculture=* tag.

[govvin]

Thanks for checking it out, @Timmy-Tesseract . Actually, according to usage history, some did using aquaculture sub-tags.

A future iteration of this challenge will suggest fixme=aquaculture when the aquaculture tag is empty, and retain existing aquaculture=* values rather than assume any.

How was your user experience? Was it helpful for you to have tags suggested, rather that copy-pasting them? Did you try revising the suggested tags, before applying any?