|
4 | 4 |
|
5 | 5 | import pytest |
6 | 6 |
|
7 | | -from apps.slack.common.handlers.ai import get_blocks, get_error_blocks, process_ai_query |
| 7 | +from apps.slack.common.handlers.ai import ( |
| 8 | + get_blocks, |
| 9 | + get_default_response, |
| 10 | + get_error_blocks, |
| 11 | + process_ai_query, |
| 12 | +) |
8 | 13 |
|
9 | 14 |
|
10 | 15 | class TestAiHandler: |
@@ -63,51 +68,87 @@ def test_get_blocks_with_empty_response(self, mock_get_error_blocks, mock_proces |
63 | 68 | assert result == error_blocks |
64 | 69 |
|
65 | 70 | @patch("apps.slack.common.handlers.ai.AgenticRAGAgent") |
66 | | - def test_process_ai_query_success(self, mock_agent_class): |
| 71 | + @patch("apps.slack.common.handlers.ai.QuestionDetector") |
| 72 | + def test_process_ai_query_success(self, mock_question_detector_class, mock_agent_class): |
67 | 73 | """Test successful AI query processing with AgenticRAGAgent.""" |
68 | 74 | query = "What is OWASP?" |
69 | 75 | expected_response = "OWASP is a security organization..." |
70 | 76 |
|
| 77 | + mock_question_detector = Mock() |
| 78 | + mock_question_detector.is_owasp_question.return_value = True |
| 79 | + mock_question_detector_class.return_value = mock_question_detector |
| 80 | + |
71 | 81 | mock_agent = Mock() |
72 | 82 | mock_agent.run.return_value = {"answer": expected_response} |
73 | 83 | mock_agent_class.return_value = mock_agent |
74 | 84 |
|
75 | 85 | result = process_ai_query(query) |
76 | 86 |
|
| 87 | + mock_question_detector_class.assert_called_once() |
| 88 | + mock_question_detector.is_owasp_question.assert_called_once_with(text=query) |
77 | 89 | mock_agent_class.assert_called_once() |
78 | 90 | mock_agent.run.assert_called_once_with(query=query) |
79 | 91 | assert result == expected_response |
80 | 92 |
|
81 | 93 | @patch("apps.slack.common.handlers.ai.AgenticRAGAgent") |
82 | | - def test_process_ai_query_failure(self, mock_agent_class): |
| 94 | + @patch("apps.slack.common.handlers.ai.QuestionDetector") |
| 95 | + def test_process_ai_query_failure(self, mock_question_detector_class, mock_agent_class): |
83 | 96 | """Test AI query processing failure raises exception.""" |
84 | 97 | query = "What is OWASP?" |
85 | 98 |
|
| 99 | + mock_question_detector = Mock() |
| 100 | + mock_question_detector.is_owasp_question.return_value = True |
| 101 | + mock_question_detector_class.return_value = mock_question_detector |
| 102 | + |
86 | 103 | mock_agent = Mock() |
87 | 104 | mock_agent.run.side_effect = Exception("AI service error") |
88 | 105 | mock_agent_class.return_value = mock_agent |
89 | 106 |
|
90 | 107 | with pytest.raises(Exception, match="AI service error"): |
91 | 108 | process_ai_query(query) |
92 | 109 |
|
| 110 | + mock_question_detector_class.assert_called_once() |
| 111 | + mock_question_detector.is_owasp_question.assert_called_once_with(text=query) |
93 | 112 | mock_agent_class.assert_called_once() |
94 | 113 | mock_agent.run.assert_called_once_with(query=query) |
95 | 114 |
|
96 | 115 | @patch("apps.slack.common.handlers.ai.AgenticRAGAgent") |
97 | | - def test_process_ai_query_returns_none(self, mock_agent_class): |
| 116 | + @patch("apps.slack.common.handlers.ai.QuestionDetector") |
| 117 | + def test_process_ai_query_returns_none(self, mock_question_detector_class, mock_agent_class): |
98 | 118 | """Test AI query processing when agent returns no answer.""" |
99 | 119 | query = "What is OWASP?" |
100 | 120 |
|
| 121 | + mock_question_detector = Mock() |
| 122 | + mock_question_detector.is_owasp_question.return_value = True |
| 123 | + mock_question_detector_class.return_value = mock_question_detector |
| 124 | + |
101 | 125 | mock_agent = Mock() |
102 | 126 | mock_agent.run.return_value = {"answer": None} |
103 | 127 | mock_agent_class.return_value = mock_agent |
104 | 128 |
|
105 | 129 | result = process_ai_query(query) |
106 | 130 |
|
| 131 | + mock_question_detector_class.assert_called_once() |
| 132 | + mock_question_detector.is_owasp_question.assert_called_once_with(text=query) |
107 | 133 | mock_agent_class.assert_called_once() |
108 | 134 | mock_agent.run.assert_called_once_with(query=query) |
109 | 135 | assert result is None |
110 | 136 |
|
| 137 | + @patch("apps.slack.common.handlers.ai.QuestionDetector") |
| 138 | + def test_process_ai_query_non_owasp_question(self, mock_question_detector_class): |
| 139 | + """Test AI query processing when question is not OWASP-related.""" |
| 140 | + query = "What is the weather today?" |
| 141 | + |
| 142 | + mock_question_detector = Mock() |
| 143 | + mock_question_detector.is_owasp_question.return_value = False |
| 144 | + mock_question_detector_class.return_value = mock_question_detector |
| 145 | + |
| 146 | + result = process_ai_query(query) |
| 147 | + |
| 148 | + mock_question_detector_class.assert_called_once() |
| 149 | + mock_question_detector.is_owasp_question.assert_called_once_with(text=query) |
| 150 | + assert result == get_default_response() |
| 151 | + |
111 | 152 | @patch("apps.slack.common.handlers.ai.markdown") |
112 | 153 | def test_get_error_blocks(self, mock_markdown): |
113 | 154 | """Test error blocks generation.""" |
|
0 commit comments