Spelling mistake in web interface pop up box - typo in code found

[peterb-aus]

I'm still trying to debug the PAUSE macro, having the source code would help! I came across another bug, not a deal breaker, just annoying.

I had this pop up at me:

This appears in both the web interface and the Orca device tab. Running 0.3.0, updated tonight.

Cancel button reads cancle, should be Cancel, capitalised like the other button and spelled correctly.

[peterb-aus]

I've found this in the Elegoo repo, in the alleged upload of the ECC firmware source. It appears in four files.

https://github.com/elegooofficial/CentauriCarbon/blob/e5c8dac7f8689a9a45e4153b80c6a6e3617f2b26/firmware/resources/e100/www/assets/i18n/network-en.json#L93

https://github.com/elegooofficial/CentauriCarbon/blob/e5c8dac7f8689a9a45e4153b80c6a6e3617f2b26/firmware/resources/e100/www/assets/i18n/network-zh-Hans.json#L93

https://github.com/elegooofficial/CentauriCarbon/blob/e5c8dac7f8689a9a45e4153b80c6a6e3617f2b26/firmware/resources/e100_lite/www/assets/i18n/network-zh-Hans.json#L93

https://github.com/elegooofficial/CentauriCarbon/blob/e5c8dac7f8689a9a45e4153b80c6a6e3617f2b26/firmware/resources/e100_lite/www/assets/i18n/network-en.json#L93

In OC, I think its this one:

https://github.com/OpenCentauri/cc-firmware/blob/33e562eb1e973db5a4863037859351b48e4a8a2f/resources/e100_lite/www/assets/i18n/network-en.json#L93

Line 187 seems to be the culprit.

185 "blackout": "Detected unfinished print tasks",
186 "resumePrint": "Resume Printing",
187 "cancleResume": "cancle",
188 "errorStatusReason": {
189 "45": "Consumables are about to run out, please replace consumables"
190 }

Not sure where to go from here.

[peterb-aus]

This is the change needed in file
https://github.com/OpenCentauri/cc-firmware/blob/33e562eb1e973db5a4863037859351b48e4a8a2f/resources/e100_lite/www/assets/i18n/network-en.json#L93

Old code line 187
187 "cancleResume": "cancle",

My suggested new code in line 187
187 "cancleResume": "Cancel",

I hope that is enough for the devs, thanks for the good work so far.

[suchmememanyskill]

Opencentauri doesn't use the public elegoo source, instead we unpack the firmware, apply patches to it then repack it. Currently the best solution as the elegoo public source is incomplete.

You might want to take a look at the base patch, where we currently apply webui patches (legacy thing as that was done before we made the new patching system).

https://github.com/OpenCentauri/cc-fw-tools/blob/main/oc-patches/base-patch/patch.sh#L84

[peterb-aus]

Opencentauri doesn't use the public elegoo source, instead we unpack the firmware, apply patches to it then repack it. Currently the best solution as the elegoo public source is incomplete.

Thanks for your help,

I searched the Elegoo source first, as my issue was commented as "present in official firmware". In my opinion, it seems the EL code is very disjointed and incoherent, Not a good starting point for a project.

It took me quite a while to find the offending line in the OC repo.

I'll leave it to you to sort out the details of if, how and when you fix the bug. All I'm doing is pointing out the error, where I think it is, and what I think will fix it. The bug doesn't worry me, but it would be nice if OC fixed it before Elegoo.

I don't want to mess with your code, I'd probably stuff it up. I don't know the details of your patching system. I'm busy with hardware projects atm.

I'm not bailing out from helping OC. I've been coding since the '60s and I've kept up to date. My expertise is mostly in testing and bug chasing, hardware and software, not so much writing from scratch. I haven't done PC coding since the TRS-80 and Amiga days, was usually working on mainframes, industrial controllers and imbedded systems. If you need something don't hesitate to ask, I'm happy to help, though I haven't much time at present.

[prokrypt]

In-printer fix:

sed -i 's/"cancle",/"Cancel",/' /app/resources/www/assets/i18n/network-en.json