Skip to content

feat: add a confirmation mode selector similar to Toad#565

Open
tibisabau wants to merge 1 commit intoOpenHands:mainfrom
tibisabau:feat/add-confirmation-mode-selector
Open

feat: add a confirmation mode selector similar to Toad#565
tibisabau wants to merge 1 commit intoOpenHands:mainfrom
tibisabau:feat/add-confirmation-mode-selector

Conversation

@tibisabau
Copy link

@tibisabau tibisabau commented Mar 3, 2026

Description

This PR implements a persistent confirmation mode setting that saves the user's preference across sessions. The confirmation policy (always-ask, always-approve, or llm-approve) is now stored in the CLI settings file and automatically loaded on startup. A visual indicator in the bottom status line shows the current confirmation mode at all times.

Key changes:

  • Added default_confirmation_policy field to CliSettings with validation
  • Modified app initialization to load saved policy from settings (CLI args still take precedence)
  • Updated ConfirmationPolicyService to persist policy changes to disk
  • Added confirmation mode indicator to InfoStatusLine widget with color coding
  • Updated tests to reflect new settings structure

The /confirm command remains available for discoverability. Users can change the mode via F2 or /confirm, and their choice persists across sessions.

Closes #314.

The code in this pull request was generated by GitHub Copilot with the Claude Sonnet 4.5 model.

Checklist if Applicable

  • The tests passed – make test (unit tests excluding snapshots)
  • Linting passed – make lint
  • Documentation has been added
  • CHANGELOG.md has been updated

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Could you post screenshots or logs, to see how it works?

@tibisabau
Copy link
Author

Thank you for the contribution! Could you post screenshots or logs, to see how it works?

AdobeExpressPhotos_9e348b84dcbc4ff8927880d066deb266_CopyEdited AdobeExpressPhotos_939413e3e91c4e14a6926c0137b9e2e1_CopyEdited AdobeExpressPhotos_ea8ccb52aa42494994507c7f263b1a81_CopyEdited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add a confirmation mode selector similar to Toad

2 participants