Skip to content

Investigation: CLI compatibility and API breakage check for PR #2133 #2343

@enyst

Description

@enyst

Context

Review of PR comment #2133 (comment).

Link verification

API breakage (Griffe)

  • Workflow: .github/workflows/api-breakage.yml (runs SDK programmatic API (Griffe) with SDK_INCLUDE_PATHS=openhands.sdk).
  • Check run for PR feat: Add ACPAgent for Agent Client Protocol integration #2133: success. Run: https://github.com/OpenHands/software-agent-sdk/actions/runs/22240640198/job/64343156160.
  • Current workflow config limits runs to rel-* release branches, but this PR still had a successful run recorded.
  • The methods mentioned in the comment (set_config_option, fork_session, new_session/load_session signature changes, acp.schema renames) are not present in the SDK public API exported via openhands.sdk.__all__. They appear to be CLI- or dependency-specific rather than SDK public surface, so Griffe did not detect a public API break.
  • Opinion: Unless we intend third-party SDK users to implement or depend on those CLI-facing hooks, I’d avoid adding them to the SDK public API for now. If we do want them public, we should formalize them on AgentBase and document a deprecation path.

Release PR

CLI SDK version

  • OpenHands-CLI main pins openhands-sdk==1.11.5, openhands-tools==1.11.5, openhands-workspace==1.11.1 in pyproject.toml.

Answer to comment question

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions