-
Notifications
You must be signed in to change notification settings - Fork 167
Closed
Labels
Description
Context
Review of PR comment #2133 (comment).
Link verification
- OpenHands-CLI PR Refactor: Move state persistence from callback to direct agent.py calls #548 (feat: implement Ctrl+C pause/interrupt flow and update SDK hash OpenHands-CLI#548): open, draft; updates SDK git rev to
b9780a1f...and bumpsagent-client-protocolto>=0.8.1. - SDK PR fix(terminal): filter terminal query sequences from captured output #2334 (fix(terminal): filter terminal query sequences from captured output #2334): open; mergeable_state reported as
blockedat time of check.
API breakage (Griffe)
- Workflow:
.github/workflows/api-breakage.yml(runsSDK programmatic API (Griffe)withSDK_INCLUDE_PATHS=openhands.sdk). - Check run for PR feat: Add ACPAgent for Agent Client Protocol integration #2133: success. Run: https://github.com/OpenHands/software-agent-sdk/actions/runs/22240640198/job/64343156160.
- Current workflow config limits runs to
rel-*release branches, but this PR still had a successful run recorded. - The methods mentioned in the comment (
set_config_option,fork_session,new_session/load_sessionsignature changes,acp.schemarenames) are not present in the SDK public API exported viaopenhands.sdk.__all__. They appear to be CLI- or dependency-specific rather than SDK public surface, so Griffe did not detect a public API break. - Opinion: Unless we intend third-party SDK users to implement or depend on those CLI-facing hooks, I’d avoid adding them to the SDK public API for now. If we do want them public, we should formalize them on
AgentBaseand document a deprecation path.
Release PR
- Latest SDK release PR: Release v1.12.0 #2302 – Release v1.12.0 (merged 2026-03-05).
CLI SDK version
- OpenHands-CLI
mainpins openhands-sdk==1.11.5, openhands-tools==1.11.5, openhands-workspace==1.11.1 inpyproject.toml.
Answer to comment question
- With CLI pinned to 1.11.5, yes: SDK fixes/features on
main(post-breaking changes) are effectively blocked for CLI use until CLI is updated. - If CLI upgrades to SDK 1.12.0 (or merges PR #548), the compatibility note should no longer apply and PRs like fix(terminal): filter terminal query sequences from captured output #2334 should be testable with the CLI.
Reactions are currently unavailable