Use Integer.valueOf for caching benefit

mgaffigan · mgaffigan · commit 956c28489bfc · 2025-07-29T11:16:42.000-05:00
Signed-off-by: Mitch Gaffigan &lt;mitch.gaffigan@comcast.net&gt;
diff --git a/client/src/com/mirth/connect/client/ui/browsers/event/EventBrowser.java b/client/src/com/mirth/connect/client/ui/browsers/event/EventBrowser.java
@@ -476,7 +476,7 @@ public void done() {
                         updateEventTable(events);
 
                         if (!events.hasNextPage()) {
-                            events.setItemCount((long)(((retrievedPageNumber - 1) * events.getPageSize()) + events.size()));
+                            events.setItemCount(Long.valueOf(((retrievedPageNumber - 1) * events.getPageSize()) + events.size()));
                             enableCountButton = false;
                         }
                     } else {
@@ -485,7 +485,7 @@ public void done() {
                             model.refreshDataVector(new Object[0][0]);
                         }
 
-                        events.setItemCount((long)((retrievedPageNumber - 1) * events.getPageSize()));
+                        events.setItemCount(Long.valueOf((retrievedPageNumber - 1) * events.getPageSize()));
                         enableCountButton = false;
                         pageNumberField.setText("0");
                     }
diff --git a/client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowser.java b/client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowser.java
@@ -968,11 +968,11 @@ public void done() {
                         }
 
                         if (!messages.hasNextPage()) {
-                            messages.setItemCount((long)(((retrievedPageNumber - 1) * messages.getPageSize()) + messages.size()));
+                            messages.setItemCount(Long.valueOf(((retrievedPageNumber - 1) * messages.getPageSize()) + messages.size()));
                             enableCountButton = false;
                         }
                     } else {
-                        messages.setItemCount((long)((retrievedPageNumber - 1) * messages.getPageSize()));
+                        messages.setItemCount(Long.valueOf((retrievedPageNumber - 1) * messages.getPageSize()));
                         enableCountButton = false;
                         pageNumberField.setText("0");
                     }
diff --git a/donkey/src/main/java/com/mirth/connect/donkey/server/data/buffered/BufferedDao.java b/donkey/src/main/java/com/mirth/connect/donkey/server/data/buffered/BufferedDao.java
@@ -77,7 +77,7 @@ public void commit() {
 
     @Override
     public void commit(boolean durable) {
-        commit((Boolean) durable);
+        commit(Boolean.valueOf(durable));
     }
 
     private void commit(Boolean durable) {
diff --git a/donkey/src/test/java/com/mirth/connect/donkey/test/DestinationConnectorTests.java b/donkey/src/test/java/com/mirth/connect/donkey/test/DestinationConnectorTests.java
@@ -328,7 +328,7 @@ private void testProcess(boolean queueNull, boolean queueEnabled, boolean queueS
 
                 if (retryCount > 0) {
                     // assert that the connector attempted to send the message the correct number of times
-                    assertEquals((Integer)(dispatcherConnectorProperties.getRetryCount() + 1), TestUtils.getSendAttempts(channel.getChannelId(), dispatchResult.getMessageId()));
+                    assertEquals(Integer.valueOf(dispatcherConnectorProperties.getRetryCount() + 1), TestUtils.getSendAttempts(channel.getChannelId(), dispatchResult.getMessageId()));
                 } else {
                     if (queueNull || !queueEnabled || queueSendFirst) {
                         // Assert that the sent content was stored
diff --git a/donkey/src/test/java/com/mirth/connect/donkey/test/DonkeyDaoTests.java b/donkey/src/test/java/com/mirth/connect/donkey/test/DonkeyDaoTests.java
@@ -1444,7 +1444,7 @@ public final void testGetMaxMessageId() throws Exception {
 
             try {
                 dao = daoFactory.getDao();
-                assertEquals(maxId, (Long)dao.getMaxMessageId(channel.getChannelId()));
+                assertEquals(maxId, Long.valueOf(dao.getMaxMessageId(channel.getChannelId())));
             } finally {
                 TestUtils.close(dao);
             }
@@ -1468,7 +1468,7 @@ public final void testGetMaxMessageId() throws Exception {
 
                 try {
                     dao = daoFactory.getDao();
-                    assertEquals(maxId, (Long)dao.getMaxMessageId(channel.getChannelId()));
+                    assertEquals(maxId, Long.valueOf(dao.getMaxMessageId(channel.getChannelId())));
                 } finally {
                     TestUtils.close(dao);
                 }
diff --git a/server/src/com/mirth/connect/server/controllers/DonkeyEngineController.java b/server/src/com/mirth/connect/server/controllers/DonkeyEngineController.java
@@ -966,11 +966,11 @@ public int compare(DashboardStatus o1, DashboardStatus o2) {
     }
 
     protected Long getSourceQueueSize(Channel channel) {
-        return (long)(channel.getSourceQueue().size());
+        return Long.valueOf(channel.getSourceQueue().size());
     }
 
     protected Long getDestinationQueueSize(DestinationConnector destinationConnector) {
-        return (long)(destinationConnector.getQueue().size());
+        return Long.valueOf(destinationConnector.getQueue().size());
     }
 
     @Override
diff --git a/server/src/org/mozilla/javascript/NativeBoolean.java b/server/src/org/mozilla/javascript/NativeBoolean.java
@@ -101,7 +101,7 @@ public Object execIdCall(IdFunctionObject f, Context cx, Scriptable scope,
             return value ? "true" : "false";
 
           case Id_toSource:
-            return value ? "new Boolean(true)" : "new Boolean(false)";
+            return value ? "(new Boolean(true))" : "(new Boolean(false))";
 
           case Id_valueOf:
             return ScriptRuntime.wrapBoolean(value);
diff --git a/server/src/org/mozilla/javascript/tools/debugger/SwingGui.java b/server/src/org/mozilla/javascript/tools/debugger/SwingGui.java
@@ -787,7 +787,7 @@ static void setResizeWeight(JSplitPane pane, double weight) {
         try {
             Method m = JSplitPane.class.getMethod("setResizeWeight",
                                                   new Class[]{double.class});
-            m.invoke(pane, new Object[]{(double)weight});
+            m.invoke(pane, new Object[]{weight});
         } catch (NoSuchMethodException exc) {
         } catch (IllegalAccessException exc) {
         } catch (java.lang.reflect.InvocationTargetException exc) {
diff --git a/server/test/com/mirth/connect/connectors/tcp/TcpDispatcherTest.java b/server/test/com/mirth/connect/connectors/tcp/TcpDispatcherTest.java
@@ -303,8 +303,8 @@ public void testMessageSentWhenOneOfMultipleClientsClosed() throws Exception {
         	}
         }
         
-        assertEquals((Integer)2, successfulSends);
-        assertEquals((Integer)2, numberOfClients);
+        assertEquals(Integer.valueOf(2), successfulSends);
+        assertEquals(Integer.valueOf(2), numberOfClients);
 	}
 	
 	/*
@@ -350,9 +350,9 @@ public void testMLLPMessageSentWhenOneOfMultipleClientsClosed() throws Exception
         		assertEquals(TEST_MESSAGE_TEMPLATE, socketResult.get("result" + entry.getKey()));
         	}
         }
-        
-        assertEquals((Integer)2, successfulSends);
-        assertEquals((Integer)2, numberOfClients);
+
+        assertEquals(Integer.valueOf(2), successfulSends);
+        assertEquals(Integer.valueOf(2), numberOfClients);
 	}
 	
 	/*
@@ -389,8 +389,8 @@ public void testMaxConnections() throws Exception {
         Integer numberOfClients = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_NO_OF_CLIENTS_KEY);
         Integer successfulSends = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_SUCCESSFUL_SENDS_KEY);
 
-        assertEquals((Integer)1, successfulSends);
-        assertEquals((Integer)1, numberOfClients);
+        assertEquals(Integer.valueOf(1), successfulSends);
+        assertEquals(Integer.valueOf(1), numberOfClients);
 	}
 	
 	/*
@@ -413,8 +413,8 @@ public void testMessageResponseWithNoConnections() throws Exception {
         Integer successfulSends = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_SUCCESSFUL_SENDS_KEY);
         
         assertEquals(Status.QUEUED, response.getStatus());
-        assertEquals((Integer)0, successfulSends);
-        assertEquals((Integer)0, numberOfClients);
+        assertEquals(Integer.valueOf(0), successfulSends);
+        assertEquals(Integer.valueOf(0), numberOfClients);
 	}
 	
 	/*
@@ -457,8 +457,8 @@ public void testMessageResponseWhenAllConnectionsClosed() throws Exception {
         Integer successfulSends = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_SUCCESSFUL_SENDS_KEY);
         
         assertEquals(Status.QUEUED, response.getStatus());
-        assertEquals((Integer)0, successfulSends);
-        assertEquals((Integer)0, numberOfClients);
+        assertEquals(Integer.valueOf(0), successfulSends);
+        assertEquals(Integer.valueOf(0), numberOfClients);
 	}
 	
 	/*
@@ -501,8 +501,8 @@ public void testMLLPMessageResponseWhenAllConnectionsClosed() throws Exception {
         Integer successfulSends = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_SUCCESSFUL_SENDS_KEY);
         
         assertEquals(Status.QUEUED, response.getStatus());
-        assertEquals((Integer)0, successfulSends);
-        assertEquals((Integer)0, numberOfClients);
+        assertEquals(Integer.valueOf(0), successfulSends);
+        assertEquals(Integer.valueOf(0), numberOfClients);
 	}
 	
 	/*
@@ -616,8 +616,8 @@ public void testWhenSendToOneOfMultipleClientsErrors() throws Exception {
         
         log(message.getConnectorMap().get(CONNECTOR_MAP_ALL_RESPONSES_KEY));
         assertEquals(Status.SENT, response.getStatus());
-        assertEquals((Integer)2, successfulSends);
-        assertEquals((Integer)3, numberOfClients);
+        assertEquals(Integer.valueOf(2), successfulSends);
+        assertEquals(Integer.valueOf(3), numberOfClients);
 	}
 	
 	@Test
diff --git a/server/test/com/mirth/connect/server/api/servlets/ChannelServletTest.java b/server/test/com/mirth/connect/server/api/servlets/ChannelServletTest.java
@@ -197,7 +197,7 @@ private void verifyChannel1(Channel channel, boolean includeCodeTemplateLibrarie
         ChannelExportData exportData = channel.getExportData();
         assertTrue(exportData.getMetadata().isEnabled());
         assertTrue(exportData.getMetadata().getPruningSettings().isArchiveEnabled());
-        assertEquals((Integer)7, exportData.getMetadata().getPruningSettings().getPruneContentDays());
+        assertEquals(Integer.valueOf(7), exportData.getMetadata().getPruningSettings().getPruneContentDays());
 
         assertEquals(2, exportData.getChannelTags().size());
         assertTrue(exportData.getChannelTags().contains(new ChannelTag("tag1", "Tag 1", new HashSet<>(Arrays.asList(new String[] { CHANNEL_ID_1, CHANNEL_ID_2 })))));

Original file line number	Diff line number	Diff line change
`@@ -476,7 +476,7 @@ public void done() {`
`476`	`476`	`updateEventTable(events);`
`477`	`477`
`478`	`478`	`if (!events.hasNextPage()) {`
`479`		`- events.setItemCount((long)(((retrievedPageNumber - 1) * events.getPageSize()) + events.size()));`
	`479`	`+ events.setItemCount(Long.valueOf(((retrievedPageNumber - 1) * events.getPageSize()) + events.size()));`
`480`	`480`	`enableCountButton = false;`
`481`	`481`	`}`
`482`	`482`	`} else {`
`@@ -485,7 +485,7 @@ public void done() {`
`485`	`485`	`model.refreshDataVector(new Object[0][0]);`
`486`	`486`	`}`
`487`	`487`
`488`		`- events.setItemCount((long)((retrievedPageNumber - 1) * events.getPageSize()));`
	`488`	`+ events.setItemCount(Long.valueOf((retrievedPageNumber - 1) * events.getPageSize()));`
`489`	`489`	`enableCountButton = false;`
`490`	`490`	`pageNumberField.setText("0");`
`491`	`491`	`}`
Original file line number	Diff line number	Diff line change
`@@ -968,11 +968,11 @@ public void done() {`
`968`	`968`	`}`
`969`	`969`
`970`	`970`	`if (!messages.hasNextPage()) {`
`971`		`- messages.setItemCount((long)(((retrievedPageNumber - 1) * messages.getPageSize()) + messages.size()));`
	`971`	`+ messages.setItemCount(Long.valueOf(((retrievedPageNumber - 1) * messages.getPageSize()) + messages.size()));`
`972`	`972`	`enableCountButton = false;`
`973`	`973`	`}`
`974`	`974`	`} else {`
`975`		`- messages.setItemCount((long)((retrievedPageNumber - 1) * messages.getPageSize()));`
	`975`	`+ messages.setItemCount(Long.valueOf((retrievedPageNumber - 1) * messages.getPageSize()));`
`976`	`976`	`enableCountButton = false;`
`977`	`977`	`pageNumberField.setText("0");`
`978`	`978`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ public void commit() {`
`77`	`77`
`78`	`78`	`@Override`
`79`	`79`	`public void commit(boolean durable) {`
`80`		`- commit((Boolean) durable);`
	`80`	`+ commit(Boolean.valueOf(durable));`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`private void commit(Boolean durable) {`
Original file line number	Diff line number	Diff line change
`@@ -966,11 +966,11 @@ public int compare(DashboardStatus o1, DashboardStatus o2) {`
`966`	`966`	`}`
`967`	`967`
`968`	`968`	`protected Long getSourceQueueSize(Channel channel) {`
`969`		`- return (long)(channel.getSourceQueue().size());`
	`969`	`+ return Long.valueOf(channel.getSourceQueue().size());`
`970`	`970`	`}`
`971`	`971`
`972`	`972`	`protected Long getDestinationQueueSize(DestinationConnector destinationConnector) {`
`973`		`- return (long)(destinationConnector.getQueue().size());`
	`973`	`+ return Long.valueOf(destinationConnector.getQueue().size());`
`974`	`974`	`}`
`975`	`975`
`976`	`976`	`@Override`