Skip to content

Commit 42aa3e3

Browse files
author
Martii
committed
Fix missing protocol for *fakeS3* which is needed for *node* v0.12.x
* Removes the previous exception found with *fakeS3* and all importing/creation of scripts. * Bump `./package.json` to reflect tested nodejs major versions... **do not use 0.12.0 on nodejitsu due to previous deploy failures during 0.10.33 static testing **NOTE** Regression tested on 0.10.xx and appears okay... retested on local pro. There are some deprecation warnings that may not be able to be addressed until node host is upgraded in #425 Applies to #581
1 parent 4d0a1a7 commit 42aa3e3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

controllers/scriptStorage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ if (isPro) {
2222
} else {
2323
// You need to install (and ruby too): https://github.com/jubos/fake-s3
2424
// Then run the fakes3.sh script or: fakes3 -r fakeS3 -p 10001
25-
var DEV_AWS_URL = process.env.DEV_AWS_URL || 'localhost:10001';
25+
var DEV_AWS_URL = process.env.DEV_AWS_URL || 'http://localhost:10001';
2626
AWS.config.update({
2727
accessKeyId: 'fakeId',
2828
secretAccessKey: 'fakeKey',

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"postinstall": "node dev/init.js"
7979
},
8080
"engines": {
81-
"node": ">=0.10.32 <0.11.0",
81+
"node": ">=0.10.32 <0.11.0 || >=0.12.0 <=0.12.2",
8282
"npm": ">=1.4.28"
8383
},
8484
"private": true

0 commit comments

Comments
 (0)