Echo msg #773
Merged
Echo msg #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The descriptions look reasonable, but I do not feel qualified to approve the sync/async window stuff. @lstipakov could you? |
selvanair
commented
Oct 27, 2025
lstipakov
reviewed
Oct 29, 2025
Fixes segfault when echo msg-notify happens with no message to display. As ShellNotify does not display with empty messages, we set space (L" ") as message to allow title-only notifications. Closes github: OpenVPN#771 Signed-off-by: Selva Nair <selva.nair@gmail.com>
We send this message from the connection thread to the main thread using a blocking SendMesssage as the echo message to display is cleared soon after. This sometimes leads to timeouts (and thus long waits). Avoid timeout using Async ShowWindow() and delaying SetForegroundWindow() as these could otherwise wait if the current foreground Window is controlled by the calling thread. Signed-off-by: Selva Nair <selva.nair@gmail.com>
lstipakov
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.