Rubocop: Stop selectively disabling cops we routinely disable

Author: nmburgan

.rubocop.yml

@@ -336,9 +336,6 @@ Metrics/ModuleLength:
 Metrics/ParameterLists:
   Enabled: false
 
-Metrics/PerceivedComplexity:
-  Enabled: true
-
 Naming/AccessorMethodName:
   Enabled: false
 
@@ -815,3 +812,9 @@ Style/FormatStringToken:
 
 Style/MultilineTernaryOperator:
   Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false

lib/vanagon/cli.rb

@@ -42,7 +42,7 @@ class CLI
           help                print this help
     DOCOPT
 
-    def parse(argv) # rubocop:disable Metrics/AbcSize
+    def parse(argv)
       parsed_options = parse_options(argv)
       sub_command = parsed_options['<command>']
       sub_argv = parsed_options['<args>']

lib/vanagon/cli/build.rb

@@ -41,7 +41,7 @@ def parse(argv)
         exit 1
       end
 
-      def run(options) # rubocop:disable Metrics/AbcSize
+      def run(options)
         project = options[:project_name]
         platform_list = options[:platforms].split(',')
         target_list = []

lib/vanagon/cli/build_requirements.rb

@@ -32,7 +32,7 @@ def parse(argv)
         exit 1
       end
 
-      def run(options) # rubocop:disable Metrics/AbcSize
+      def run(options)
         platform = options[:platform]
         project = options[:project_name]
         driver = Vanagon::Driver.new(platform, project)

lib/vanagon/cli/list.rb

@@ -29,7 +29,7 @@ def output(list, use_spaces)
         return list
       end
 
-      def run(options) # rubocop:disable Metrics/AbcSize
+      def run(options)
         check_directories(options)
 
         default_list = topic_list(File.dirname(__FILE__), '..', 'platform', 'defaults')

lib/vanagon/component.rb

@@ -156,7 +156,7 @@ def self.load_component(name, configdir, settings, platform)
     # @param settings [Hash] the settings to be used in the component
     # @param platform [Vanagon::Platform] the platform to build the component for
     # @return [Vanagon::Component] the component with the given settings and platform
-    def initialize(name, settings, platform) # rubocop:disable Metrics/AbcSize
+    def initialize(name, settings, platform)
       @name = name
       @settings = settings
       @platform = platform
@@ -313,7 +313,7 @@ def deprecated_rewrite_url
     # makefile template
     #
     # @param workdir [String] working directory to put the source into
-    def get_source(workdir, cachedir = nil) # rubocop:disable Metrics/AbcSize, Metrics/PerceivedComplexity
+    def get_source(workdir, cachedir = nil)
       opts = options.merge({ workdir: workdir, cachedir: cachedir, dirname: dirname })
       if url || !mirrors.empty?
         if %w[y yes true 1].include? ENV.fetch('VANAGON_USE_MIRRORS', 'n').downcase

lib/vanagon/component/dsl.rb

@@ -176,7 +176,7 @@ def conflicts(pkgname, version = nil)
       #        service_type [String] type of the service (network, application, system, etc)
       #        init_system [String] the init system on which to install service (sysv, systemd)
       #        link_target [String] executable service file should be linked to
-      def install_service(service_file, default_file = nil, service_name = @component.name, **options) # rubocop:disable Metrics/AbcSize
+      def install_service(service_file, default_file = nil, service_name = @component.name, **options)
         init_system = options[:init_system] || @component.platform.servicetype
         servicedir = @component.platform.get_service_dir(init_system)
 
@@ -246,7 +246,7 @@ def install_service(service_file, default_file = nil, service_name = @component.
       # @param owner  [String] owner of the file
       # @param group  [String] group owner of the file
       # # @param sudo   [Boolean] whether to use sudo to create the file and set mode
-      def install_file(source, target, mode: nil, owner: nil, group: nil, sudo: false) # rubocop:disable Metrics/AbcSize
+      def install_file(source, target, mode: nil, owner: nil, group: nil, sudo: false)
         sudo_check = sudo ? "#{sudo_bin} " : ""
 
         @component.install << "#{sudo_check}#{@component.platform.install} -d '#{File.dirname(target)}'"
@@ -421,7 +421,7 @@ def add_source(uri, options = {})
       # @param mode [String] octal mode to apply to the directory
       # @param owner [String] owner of the directory
       # @param group [String] group of the directory
-      def directory(dir, mode: nil, owner: nil, group: nil) # rubocop:disable Metrics/AbcSize
+      def directory(dir, mode: nil, owner: nil, group: nil)
         install_flags = ['-d']
         if @component.platform.is_windows?
           unless mode.nil? && owner.nil? && group.nil?

lib/vanagon/component/rules.rb

@@ -47,7 +47,7 @@ def initialize(component, project, platform)
       # in the returned rules.
       #
       # @return [Array<Makefile::Rule>]
-      def rules # rubocop:disable Metrics/AbcSize
+      def rules
         list_of_rules = [
           component_rule,
           unpack_rule,

lib/vanagon/component/source.rb

@@ -19,7 +19,7 @@ class << self
         # @param workdir [String] working directory to fetch the source into
         # @param cacheedir [String] directory to cache source files and git repos
         # @return [Vanagon::Component::Source] the correct subtype for the given source
-        def source(uri_instance, **options) # rubocop:disable Metrics/AbcSize
+        def source(uri_instance, **options)
           # Sometimes the uri comes in as a string, but sometimes it's already been
           # coerced into a URI object. The individual source providers will turn
           # the passed uri into a URI object if needed, but for this method we

lib/vanagon/component/source/git.rb

@@ -94,7 +94,7 @@ def default_options # rubocop:disable Lint/DuplicateMethods
         # @param url [String] url of git repo to use as source
         # @param ref [String] ref to checkout from git repo
         # @param workdir [String] working directory to clone into
-        def initialize(url, workdir:, cachedir: nil, **options) # rubocop:disable Metrics/AbcSize
+        def initialize(url, workdir:, cachedir: nil, **options)
           opts = default_options.merge(options.reject { |k, v| v.nil? })
 
           # Ensure that #url returns a URI object