Improve clang tooling workflows

Author: bialger

.github/workflows/ci_tests.yml

@@ -142,37 +142,58 @@ jobs:
           sudo apt-get update && sudo apt-get -y install clang-format
 
       - name: Check code style
+        shell: bash
         run: |
-          # Find all C++ source files
-          find . -name "*.cpp" -o -name "*.hpp" -o -name "*.c" -o -name "*.h" | \
-          grep -v "./build/" | grep -v "./cmake-build" | grep -v "./_deps/" | \
-          xargs clang-format --dry-run --Werror
+          mapfile -t files < <(git ls-files '*.c' '*.cpp' '*.h' '*.hpp')
+
+          if [ "${#files[@]}" -eq 0 ]; then
+            echo "No C/C++ files to check."
+            exit 0
+          fi
+
+          clang-format --dry-run --Werror "${files[@]}" 2>format_output.txt || {
+            cat format_output.txt
+            exit 1
+          }
 
       - name: Comment on style issues
-        if: failure()
+        if: failure() && github.event_name == 'pull_request'
         uses: actions/github-script@v7
         with:
           script: |
             const fs = require('fs');
             const { execSync } = require('child_process');
-            
+
             try {
               // Get list of files that need formatting
-              const files = execSync('find . -name "*.cpp" -o -name "*.hpp" -o -name "*.c" -o -name "*.h" | grep -v "./build/" | grep -v "./cmake-build" | grep -v "./_deps/"', { encoding: 'utf8' }).trim().split('\n');
-              
+              const rawFiles = execSync('git ls-files "*.c" "*.cpp" "*.h" "*.hpp"', { encoding: 'utf8' }).trim();
+
+              if (!rawFiles) {
+                console.log('No files require formatting checks.');
+                return;
+              }
+
+              const files = rawFiles.split('\n');
+
               let comment = '## 🎨 Code Style Issues Found\n\n';
               comment += 'The following files have formatting issues:\n\n';
-              
+              let hasIssues = false;
+
               for (const file of files) {
                 try {
                   const result = execSync(`clang-format --dry-run --Werror "${file}" 2>&1`, { encoding: 'utf8' });
                 } catch (error) {
                   comment += `- \`${file}\`: Formatting issues detected\n`;
+                  hasIssues = true;
                 }
               }
-              
-              comment += '\nPlease run `clang-format -i <file>` to fix formatting issues.';
-              
+
+              if (!hasIssues) {
+                comment += 'No files with formatting issues were detected.';
+              } else {
+                comment += '\nPlease run `clang-format -i <file>` to fix formatting issues.';
+              }
+
               github.rest.issues.createComment({
                 issue_number: context.issue.number,
                 owner: context.repo.owner,
@@ -198,35 +219,38 @@ jobs:
           cmake -S . -B cmake-build-tidy -DCMAKE_BUILD_TYPE=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
 
       - name: Run clang-tidy
+        shell: bash
         run: |
-          # Find all C++ source files
-          find . -name "*.cpp" -o -name "*.hpp" | \
-          grep -v "./build/" | grep -v "./cmake-build" | grep -v "./_deps/" | \
-          xargs clang-tidy -p cmake-build-tidy --warnings-as-errors=* --format-style=file || true
+          mapfile -t files < <(git ls-files '*.c' '*.cpp')
+
+          if [ "${#files[@]}" -eq 0 ]; then
+            echo "No C/C++ files to analyze."
+            touch tidy_output.txt
+            exit 0
+          fi
+
+          clang-tidy "${files[@]}" -p cmake-build-tidy --format-style=file > tidy_output.txt 2>&1 || true
+          touch tidy_output.txt
 
       - name: Count warnings and errors
         id: count_issues
         run: |
-          # Run clang-tidy and capture output
-          find . -name "*.cpp" -o -name "*.hpp" | \
-          grep -v "./build/" | grep -v "./cmake-build" | grep -v "./_deps/" | \
-          xargs clang-tidy -p cmake-build-tidy --format-style=file > tidy_output.txt 2>&1 || true
-          
           # Count errors and warnings
           errors=$(grep -c "error:" tidy_output.txt || echo "0")
           warnings=$(grep -c "warning:" tidy_output.txt || echo "0")
-          
+
           echo "errors=$errors" >> $GITHUB_OUTPUT
           echo "warnings=$warnings" >> $GITHUB_OUTPUT
-          
+
           # Fail if more than 3 warnings or any errors
           if [ "$errors" -gt 0 ] || [ "$warnings" -gt 3 ]; then
             echo "clang-tidy found $errors errors and $warnings warnings"
+            cat tidy_output.txt
             exit 1
           fi
 
       - name: Comment on quality issues
-        if: failure()
+        if: failure() && github.event_name == 'pull_request'
         uses: actions/github-script@v7
         with:
           script: |