Skip to content

Caution: using empty lists as default arguments may cause unintended side effects! #3

@osmart

Description

@osmart

In Python using an empty list as a default argument to a function or method is a mistake.
For a great explanation of why please see https://nikos7am.com/posts/mutable-default-arguments/

pdbecif uses empty lists as default arguments extensively for instance

def parse(
self,
file_path,
ignoreCategories=[],
preserve_token_order=False,
onlyCategories=[],
):

If ignoreCategories or onlyCategories are used then they may well be reused on subsequent calls.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions