Skip to content

Commit 38c1402

Browse files
Progi1984Progi1984
committed
Fixed PHPStan
1 parent 725aacc commit 38c1402

File tree

9 files changed

+49
-24
lines changed

9 files changed

+49
-24
lines changed

‎tests/PhpPresentation/Tests/Shape/AbstractGraphicTest.php‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,11 @@ public function testWidthAndHeight(): void
3434
{
3535
$min = 10;
3636
$max = 20;
37-
/** @var AbstractGraphic $stub */
3837
if (method_exists($this, 'getMockForAbstractClass')) {
38+
/** @var AbstractGraphic $stub */
3939
$stub = $this->getMockForAbstractClass(AbstractGraphic::class);
4040
} else {
41+
/** @var AbstractGraphic $stub */
4142
$stub = new class() extends AbstractGraphic {
4243
};
4344
}
@@ -72,10 +73,11 @@ public function testWidthAndHeight2(): void
7273
{
7374
$min = 10;
7475
$max = 20;
75-
/** @var AbstractGraphic $stub */
7676
if (method_exists($this, 'getMockForAbstractClass')) {
77+
/** @var AbstractGraphic $stub */
7778
$stub = $this->getMockForAbstractClass(AbstractGraphic::class);
7879
} else {
80+
/** @var AbstractGraphic $stub */
7981
$stub = new class() extends AbstractGraphic {
8082
};
8183
}

‎tests/PhpPresentation/Tests/Shape/Chart/Type/AbstractTest.php‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,11 @@ public function testHashIndex(): void
5252

5353
public function testSeries(): void
5454
{
55-
/** @var AbstractType $stub */
5655
if (method_exists($this, 'getMockForAbstractClass')) {
56+
/** @var AbstractType $stub */
5757
$stub = $this->getMockForAbstractClass(AbstractType::class);
5858
} else {
59+
/** @var AbstractType $stub */
5960
$stub = new class() extends AbstractType {
6061
public function getHashCode(): string
6162
{
@@ -84,10 +85,11 @@ public function testClone(): void
8485
new Series(),
8586
];
8687

87-
/** @var AbstractType $stub */
8888
if (method_exists($this, 'getMockForAbstractClass')) {
89+
/** @var AbstractType $stub */
8990
$stub = $this->getMockForAbstractClass(AbstractType::class);
9091
} else {
92+
/** @var AbstractType $stub */
9193
$stub = new class() extends AbstractType {
9294
public function getHashCode(): string
9395
{

‎tests/PhpPresentation/Tests/Slide/AbstractSlideTest.php‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,11 @@ class AbstractSlideTest extends TestCase
3838
{
3939
public function testCollection(): void
4040
{
41-
/** @var AbstractSlide $object */
4241
if (method_exists($this, 'getMockForAbstractClass')) {
42+
/** @var AbstractSlide $object */
4343
$object = $this->getMockForAbstractClass(AbstractSlide::class);
4444
} else {
45+
/** @var AbstractSlide $object */
4546
$object = new class() extends AbstractSlide {
4647
};
4748
}
@@ -63,10 +64,11 @@ public function testCollection(): void
6364

6465
public function testAdd(): void
6566
{
66-
/** @var AbstractSlide $object */
6767
if (method_exists($this, 'getMockForAbstractClass')) {
68+
/** @var AbstractSlide $object */
6869
$object = $this->getMockForAbstractClass(AbstractSlide::class);
6970
} else {
71+
/** @var AbstractSlide $object */
7072
$object = new class() extends AbstractSlide {
7173
};
7274
}
@@ -82,10 +84,11 @@ public function testAdd(): void
8284

8385
public function testSearchShapes(): void
8486
{
85-
/** @var AbstractSlide $object */
8687
if (method_exists($this, 'getMockForAbstractClass')) {
88+
/** @var AbstractSlide $object */
8789
$object = $this->getMockForAbstractClass(AbstractSlide::class);
8890
} else {
91+
/** @var AbstractSlide $object */
8992
$object = new class() extends AbstractSlide {
9093
};
9194
}

‎tests/PhpPresentation/Tests/Slide/AnimationTest.php‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,11 @@ class AnimationTest extends TestCase
3333
{
3434
public function testShape(): void
3535
{
36-
/** @var AbstractShape $oStub */
3736
if (method_exists($this, 'getMockForAbstractClass')) {
37+
/** @var AbstractShape $oStub */
3838
$oStub = $this->getMockForAbstractClass(AbstractShape::class);
3939
} else {
40+
/** @var AbstractShape $oStub */
4041
$oStub = new class() extends AbstractShape {
4142
};
4243
}

‎tests/PhpPresentation/Tests/Slide/SlideLayoutTest.php‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,11 @@ class SlideLayoutTest extends TestCase
3333
{
3434
public function testBase(): void
3535
{
36-
/** @var SlideMaster $mockSlideMaster */
3736
if (method_exists($this, 'getMockForAbstractClass')) {
37+
/** @var SlideMaster $mockSlideMaster */
3838
$mockSlideMaster = $this->getMockForAbstractClass(SlideMaster::class);
3939
} else {
40+
/** @var SlideMaster $mockSlideMaster */
4041
$mockSlideMaster = new class() extends SlideMaster {
4142
};
4243
}
@@ -49,10 +50,11 @@ public function testBase(): void
4950

5051
public function testLayoutName(): void
5152
{
52-
/** @var SlideMaster $mockSlideMaster */
5353
if (method_exists($this, 'getMockForAbstractClass')) {
54+
/** @var SlideMaster $mockSlideMaster */
5455
$mockSlideMaster = $this->getMockForAbstractClass(SlideMaster::class);
5556
} else {
57+
/** @var SlideMaster $mockSlideMaster */
5658
$mockSlideMaster = new class() extends SlideMaster {
5759
};
5860
}
@@ -69,10 +71,11 @@ public function testLayoutName(): void
6971

7072
public function testSlideMaster(): void
7173
{
72-
/** @var SlideMaster $mockSlideMaster */
7374
if (method_exists($this, 'getMockForAbstractClass')) {
75+
/** @var SlideMaster $mockSlideMaster */
7476
$mockSlideMaster = $this->getMockForAbstractClass(SlideMaster::class);
7577
} else {
78+
/** @var SlideMaster $mockSlideMaster */
7679
$mockSlideMaster = new class() extends SlideMaster {
7780
};
7881
}

‎tests/PhpPresentation/Tests/Slide/SlideMasterTest.php‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,11 @@ public function testLayout(): void
5353
$object = new SlideMaster();
5454

5555
// Mock Post
56-
/** @var SlideLayout $mockSlideLayout */
5756
if (method_exists($this, 'getMockForAbstractClass')) {
57+
/** @var SlideLayout $mockSlideLayout */
5858
$mockSlideLayout = $this->getMockForAbstractClass(SlideLayout::class, [$object]);
5959
} else {
60+
/** @var SlideLayout $mockSlideLayout */
6061
$mockSlideLayout = new class($object) extends SlideLayout {
6162
};
6263
}
@@ -70,19 +71,21 @@ public function testLayout(): void
7071
public function testSchemeColors(): void
7172
{
7273
// Mock Pre
73-
/** @var SchemeColor $mockSchemeColorAccent1 */
7474
if (method_exists($this, 'getMockForAbstractClass')) {
75+
/** @var SchemeColor $mockSchemeColorAccent1 */
7576
$mockSchemeColorAccent1 = $this->getMockForAbstractClass(SchemeColor::class);
7677
} else {
78+
/** @var SchemeColor $mockSchemeColorAccent1 */
7779
$mockSchemeColorAccent1 = new class() extends SchemeColor {
7880
};
7981
}
8082
$mockSchemeColorAccent1->setValue('accent1');
8183
$mockSchemeColorAccent1->setRGB('ABCDEF');
82-
/** @var SchemeColor $mockSchemeColorNew */
8384
if (method_exists($this, 'getMockForAbstractClass')) {
85+
/** @var SchemeColor $mockSchemeColorNew */
8486
$mockSchemeColorNew = $this->getMockForAbstractClass(SchemeColor::class);
8587
} else {
88+
/** @var SchemeColor $mockSchemeColorNew */
8689
$mockSchemeColorNew = new class() extends SchemeColor {
8790
};
8891
}
@@ -104,10 +107,11 @@ public function testSchemeColors(): void
104107
public function testTextStyles(): void
105108
{
106109
// Mock Pre
107-
/** @var TextStyle $mockTextStyle */
108110
if (method_exists($this, 'getMockForAbstractClass')) {
111+
/** @var TextStyle $mockTextStyle */
109112
$mockTextStyle = $this->getMockForAbstractClass(TextStyle::class);
110113
} else {
114+
/** @var TextStyle $mockTextStyle */
111115
$mockTextStyle = new class() extends TextStyle {
112116
};
113117
}

‎tests/PhpPresentation/Tests/SlideTest.php‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,11 @@ public function testSlideMasterId(): void
7777

7878
public function testAnimations(): void
7979
{
80-
/** @var Animation $oStub */
8180
if (method_exists($this, 'getMockForAbstractClass')) {
81+
/** @var Animation $oStub */
8282
$oStub = $this->getMockForAbstractClass(Animation::class);
8383
} else {
84+
/** @var Animation $oStub */
8485
$oStub = new class() extends Animation {
8586
};
8687
}
@@ -101,10 +102,11 @@ public function testAnimations(): void
101102

102103
public function testBackground(): void
103104
{
104-
/** @var AbstractBackground $oStub */
105105
if (method_exists($this, 'getMockForAbstractClass')) {
106+
/** @var AbstractBackground $oStub */
106107
$oStub = $this->getMockForAbstractClass(AbstractBackground::class);
107108
} else {
109+
/** @var AbstractBackground $oStub */
108110
$oStub = new class() extends AbstractBackground {
109111
};
110112
}

‎tests/PhpPresentation/Tests/Writer/AbstractWriterTest.php‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
* Test class for AbstractWriter.
3333
*
3434
* @coversDefaultClass \AbstractWriter
35+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
3536
*/
3637
class AbstractWriterTest extends TestCase
3738
{
@@ -40,28 +41,33 @@ class AbstractWriterTest extends TestCase
4041
*/
4142
public function testConstruct(): void
4243
{
43-
/** @var AbstractWriter $oStubWriter */
4444
if (method_exists($this, 'getMockForAbstractClass')) {
45+
/** @var AbstractWriter $oStubWriter */
4546
$oStubWriter = $this->getMockForAbstractClass(AbstractWriter::class);
4647
} else {
48+
/** @var AbstractWriter $oStubWriter */
4749
$oStubWriter = new class() extends AbstractWriter {
4850
};
4951
}
50-
/** @var ZipInterface $oStubZip */
5152
if (method_exists($this, 'getMockForAbstractClass')) {
53+
/** @var ZipInterface $oStubZip */
5254
$oStubZip = $this->getMockForAbstractClass(ZipInterface::class);
5355
} else {
56+
/** @var ZipInterface $oStubZip */
5457
$oStubZip = new class() implements ZipInterface {
55-
public function open($filename): void
58+
public function open($filename)
5659
{
60+
return $this;
5761
}
5862

59-
public function close(): void
63+
public function close()
6064
{
65+
return $this;
6166
}
6267

63-
public function addFromString(string $localname, string $contents, bool $withCompression = true): void
68+
public function addFromString(string $localname, string $contents, bool $withCompression = true)
6469
{
70+
return $this;
6571
}
6672
};
6773
}
@@ -85,10 +91,11 @@ public function testAllDrawingsIncludesMasterSlides(): void
8591
$masterSlide = $masterSlides[0];
8692
$masterSlide->createDrawingShape();
8793

88-
/** @var TestAbstractWriter $writer */
8994
if (method_exists($this, 'getMockForAbstractClass')) {
95+
/** @var TestAbstractWriter $writer */
9096
$writer = $this->getMockForAbstractClass(TestAbstractWriter::class);
9197
} else {
98+
/** @var TestAbstractWriter $writer */
9299
$writer = new class() extends TestAbstractWriter {
93100
};
94101
}

‎tests/PhpPresentation/Tests/Writer/PowerPoint2007/PptChartsTest.php‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,10 +272,11 @@ public function testPlotAreaBadType(): void
272272
$oSlide = $this->oPresentation->getActiveSlide();
273273
$oShape = $oSlide->createChartShape();
274274
$oShape->setResizeProportional(false)->setHeight(550)->setWidth(700)->setOffsetX(120)->setOffsetY(80);
275-
/** @var AbstractType $stub */
276275
if (method_exists($this, 'getMockForAbstractClass')) {
276+
/** @var AbstractType $stub */
277277
$stub = $this->getMockForAbstractClass(AbstractType::class);
278278
} else {
279+
/** @var AbstractType $stub */
279280
$stub = new class() extends AbstractType {
280281
public function getHashCode(): string
281282
{

0 commit comments

Comments
 (0)