Skip to content

[BUG]: star_1.spin_orbit_tilt_second_SN's range is defined differently from other tilts. #748

@ZepeiX

Description

@ZepeiX

Describe the bug

star_1.spin_orbit_tilt_second_SN is calculated based on star_1.spin_orbit_tilt_first_SN and star_2.spin_orbit_tilt_second_SN. The latter two is defined in [-pi, pi] but the former is in [0, pi]

Expected behavior
The sign of star_1.spin_orbit_tilt_first_SN and star_2.spin_orbit_tilt_second_SN is needed when calculating star_1.spin_orbit_tilt_second_SN. But the sign is then not important for the final output of the star1 and star2 tilt. We ether put efforts to figure out the sign of star_1.spin_orbit_tilt_first_SN ([-pi, pi]), or simply output the absolute values ([0, pi]).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions