Skip to content

[BUG]: Is singlestar.metallicity the absolute mass fraction of metals, or the ratio to solar fraction? #787

@ezapartas

Description

@ezapartas

In the singlestar class, from what I understand metallicity gets the values from the population run:
setattr(self, 'metallicity', kwargs.pop('metallicity', 1.0))
and
Z_div_Zsun = self.metallicity

However, the declaration of the variable in the singlestar properties is
'metallicity', # initial mass fraction of metals
So I am not sure if for Zsolar, singlestar.metallicity = 0.142 or 1.0
Do we just need to change the comment above next to the declaration?
Can we make sure that we are consistent across the posydon code for the use of singlestar.metallicity?

Metadata

Metadata

Labels

documentationImprovements or additions to documentationquestionFurther information is requested

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions