Skip to content

Commit 6c9f244

Browse files
committed
update dependencies and updated tests to work with new robolectric
1 parent fa2c741 commit 6c9f244

File tree

10 files changed

+32
-148
lines changed

10 files changed

+32
-148
lines changed

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
11
Change Log
22
==========
33

4+
5+
Version 1.0.1 *(2013-04-01)*
6+
----------------------------
7+
8+
* Updated dependencies
9+
410
Version 1.0.0 *(2013-04-01)*
511
----------------------------
612

7-
Initial release.
13+
* Initial release.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Download [the latest JAR][1] or grab via Maven:
3333
<dependency>
3434
<groupId>de.psdev.slf4j-android-logger</groupId>
3535
<artifactId>slf4j-android-logger</artifactId>
36-
<version>1.0.0</version>
36+
<version>1.0.1</version>
3737
</dependency>
3838
```
3939

pom.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,15 @@
6363

6464
<!-- Dependency Versions -->
6565
<android.version>4.1.1.4</android.version>
66-
<slf4j-api.version>1.7.4</slf4j-api.version>
67-
<junit.version>4.10</junit.version>
68-
<robolectric.version>1.2</robolectric.version>
66+
<slf4j-api.version>1.7.5</slf4j-api.version>
67+
<junit.version>4.11</junit.version>
68+
<robolectric.version>2.1.1</robolectric.version>
6969

7070
<!-- Plugin Versions -->
71-
<maven-compiler-plugin.version>3.0</maven-compiler-plugin.version>
71+
<maven-compiler-plugin.version>3.1</maven-compiler-plugin.version>
7272
<maven-source-plugin.version>2.2.1</maven-source-plugin.version>
73-
<maven-javadoc-plugin.version>2.9</maven-javadoc-plugin.version>
74-
<maven-release-plugin.version>2.4</maven-release-plugin.version>
73+
<maven-javadoc-plugin.version>2.9.1</maven-javadoc-plugin.version>
74+
<maven-release-plugin.version>2.4.1</maven-release-plugin.version>
7575
<maven-gpg-plugin.version>1.4</maven-gpg-plugin.version>
7676
</properties>
7777

@@ -99,7 +99,7 @@
9999
<scope>test</scope>
100100
</dependency>
101101
<dependency>
102-
<groupId>com.pivotallabs</groupId>
102+
<groupId>org.robolectric</groupId>
103103
<artifactId>robolectric</artifactId>
104104
<version>${robolectric.version}</version>
105105
<scope>test</scope>

src/test/android/AndroidManifest.xml

Lines changed: 0 additions & 48 deletions
This file was deleted.

src/test/android/project.properties

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/test/android/res/values/strings.xml

Lines changed: 0 additions & 43 deletions
This file was deleted.

src/test/java/de/psdev/slf4j/android/logger/AndroidLoggerAdapterTest.java

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,34 +17,34 @@
1717
package de.psdev.slf4j.android.logger;
1818

1919
import android.util.Log;
20-
import com.xtremelabs.robolectric.Robolectric;
20+
import org.hamcrest.CoreMatchers;
2121
import org.junit.After;
2222
import org.junit.Before;
2323
import org.junit.Test;
2424
import org.junit.runner.RunWith;
25+
import org.robolectric.RobolectricTestRunner;
26+
import org.robolectric.annotation.Config;
2527
import org.slf4j.Logger;
2628
import org.slf4j.LoggerFactory;
2729

28-
import static org.junit.Assert.assertEquals;
29-
import static org.junit.Assert.assertThat;
30-
import static org.junit.Assert.assertTrue;
31-
import static org.junit.matchers.JUnitMatchers.containsString;
30+
import static org.junit.Assert.*;
3231

33-
@RunWith(CustomRobolectricTestRunner.class)
32+
@RunWith(RobolectricTestRunner.class)
33+
@Config(manifest = Config.NONE, shadows = {EnhancedShadowLog.class})
3434
public class AndroidLoggerAdapterTest {
3535

3636
private Logger mLogger;
3737

3838
@Before
3939
public void setUp() throws Exception {
40-
Robolectric.bindShadowClass(EnhancedShadowLog.class);
4140
mLogger = LoggerFactory.getLogger(AndroidLoggerAdapterTest.class);
4241
EnhancedShadowLog.stream = System.out;
4342
}
4443

4544
@Test
4645
public void testInitialization() throws Exception {
47-
assertEquals("should have read correct log tag from properties", "TestLogTag", AndroidLoggerAdapter.getLogTag());
46+
assertEquals("should have read correct log tag from properties", "TestLogTag",
47+
AndroidLoggerAdapter.getLogTag());
4848
assertEquals("should have correct name", AndroidLoggerAdapterTest.class.getName(), mLogger.getName());
4949
assertEquals("should have correct log level", Log.VERBOSE, AndroidLoggerAdapter.getLogLevel());
5050
}
@@ -269,7 +269,8 @@ public void testInnerclassMatching() throws Exception {
269269
final InnerClassTest innerClassTest = new InnerClassTest();
270270
innerClassTest.doSomething();
271271
assertLog(Log.INFO, "inner class match");
272-
assertThat("should contain correct class name", EnhancedShadowLog.getLogs().get(0).msg, containsString("InnerClassTest"));
272+
assertThat("should contain correct class name", EnhancedShadowLog.getLogs().get(0).msg,
273+
CoreMatchers.containsString("InnerClassTest"));
273274
}
274275

275276
@After
@@ -283,12 +284,14 @@ private static void assertLog(final int expectedLogLevel, final String expectedC
283284
assertLog(expectedLogLevel, expectedContainedText, null);
284285
}
285286

286-
private static void assertLog(final int expectedLogLevel, final String expectedContainedText, final Throwable expectedThrowable) {
287+
private static void assertLog(final int expectedLogLevel, final String expectedContainedText,
288+
final Throwable expectedThrowable) {
287289
assertEquals("should have logged 1 message", 1L, EnhancedShadowLog.getLogs().size());
288290
final EnhancedShadowLog.LogItem logItem = EnhancedShadowLog.getLogs().get(0);
289291
assertEquals("should have correct type", expectedLogLevel, logItem.type);
290-
assertThat("should contain message", logItem.msg, containsString(expectedContainedText));
291-
assertThat("should contain class", logItem.msg, containsString(AndroidLoggerAdapterTest.class.getSimpleName()));
292+
assertThat("should contain message", logItem.msg, CoreMatchers.containsString(expectedContainedText));
293+
assertThat("should contain class", logItem.msg, CoreMatchers.containsString(
294+
AndroidLoggerAdapterTest.class.getSimpleName()));
292295
assertEquals("should have correct log tag", "TestLogTag", logItem.tag);
293296
if (expectedThrowable != null) {
294297
assertEquals("should have logged the correct throwable", expectedThrowable, logItem.throwable);

src/test/java/de/psdev/slf4j/android/logger/CustomRobolectricTestRunner.java

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/test/java/de/psdev/slf4j/android/logger/EnhancedShadowLog.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@
4040
package de.psdev.slf4j.android.logger;
4141

4242
import android.util.Log;
43-
import com.xtremelabs.robolectric.internal.Implementation;
44-
import com.xtremelabs.robolectric.internal.Implements;
43+
import org.robolectric.annotation.Implementation;
44+
import org.robolectric.annotation.Implements;
4545

4646
import java.io.PrintStream;
4747
import java.io.PrintWriter;

src/test/java/de/psdev/slf4j/android/logger/R.java

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)