Avoid actually setting unlimited value in policy

Author: bording

src/NServiceBus.Transport.RabbitMQ.Tests/BrokerVerifierTests.cs

@@ -49,8 +49,9 @@ public async Task ValidateDeliveryLimit_Should_Set_Delivery_Limit_Policy()
         for (int i = 0; i < attempts; i++)
         {
             var queue = await managementClient.GetQueue(queueName);
+            var deliveryLimit = queue.GetDeliveryLimit();
 
-            if (queue.DeliveryLimit == -1 && queue.AppliedPolicyName == policyName)
+            if (deliveryLimit == Queue.BigValueInsteadOfActuallyUnlimited && queue.AppliedPolicyName == policyName)
             {
                 // Policy applied successfully
                 return;

src/NServiceBus.Transport.RabbitMQ/Administration/BrokerVerifier.cs

@@ -171,7 +171,7 @@ bool ShouldOverrideDeliveryLimit(Queue queue)
 
         var limit = queue.GetDeliveryLimit();
 
-        if (limit == -1)
+        if (limit is Queue.UnlimitedDeliveryLimitIndicatorValue or Queue.BigValueInsteadOfActuallyUnlimited)
         {
             return false;
         }
@@ -201,7 +201,7 @@ async Task SetDeliveryLimitViaPolicy(Queue queue, CancellationToken cancellation
         var policy = new Policy
         {
             ApplyTo = PolicyTarget.QuorumQueues,
-            Definition = new PolicyDefinition { DeliveryLimit = -1 },
+            Definition = new PolicyDefinition { DeliveryLimit = Queue.BigValueInsteadOfActuallyUnlimited },
             Pattern = queue.Name,
             Priority = 0
         };

src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Converters/DeliveryLimitConverter.cs

@@ -20,7 +20,7 @@ public override int Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSeri
 
             if (string.Equals(value, "unlimited", StringComparison.OrdinalIgnoreCase))
             {
-                return -1;
+                return Queue.UnlimitedDeliveryLimitIndicatorValue;
             }
 
             throw new JsonException($"Unexpected string value for delivery limit: {value}");

src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Models/Queue.cs

@@ -67,6 +67,9 @@ public int GetDeliveryLimit()
             limit = 0;
         }
 
-        return limit ?? -1;
+        return limit ?? UnlimitedDeliveryLimitIndicatorValue;
     }
+
+    public const int UnlimitedDeliveryLimitIndicatorValue = -1_000;
+    public const int BigValueInsteadOfActuallyUnlimited = 100_000;
 }