TNetData removed from TFrameNodeStats.Create

Calling property TNetData.NetData is unsafe.
Which calls TNetData.Create
Which calls procedure TECPrivateKey.GenerateRandomPrivateKey(EC_OpenSSL_NID : Word);
Which relies on UCrypto which is not yet initialized,
Which leads to access violation because UCrypto API routine pointers not loaded.

TNetData code moved back to procedure TFRMWallet.FinishedLoadingApp;

Author: SkybuckFlying

src/gui-classic/Frames/UFrameNodeStats.pas

@@ -25,16 +25,16 @@   TFrameNodeStats = class(TFrame)
 
     FMustProcessNetConnectionUpdated : Boolean;
 
-    procedure OnNetConnectionsUpdated(Sender : TObject);
-    procedure OnNetBlackListUpdated(Sender : TObject);
-    procedure OnNetNodeServersUpdated(Sender: TObject);
-
     procedure CM_NetConnectionUpdated(var Msg: TMessage); message CM_PC_NetConnectionUpdated;
 
 
   public
     { Public declarations }
 
+    procedure OnNetConnectionsUpdated(Sender : TObject);
+    procedure OnNetBlackListUpdated(Sender : TObject);
+    procedure OnNetNodeServersUpdated(Sender: TObject);
+
     constructor Create(AOwner: TComponent); override;
     destructor Destroy; override;
   end;
@@ -63,9 +63,14 @@ constructor TFrameNodeStats.Create(AOwner: TComponent);
 
   FMustProcessNetConnectionUpdated := false;
 
+  // Skybuck:
+  // unsafe, must be called by FRMWallet first, otherwise UCrypto not initialised.
+  // or initialize UCrypto before FRMWallet is create.
+{
   TNetData.NetData.OnNetConnectionsUpdated := OnNetConnectionsUpdated;
   TNetData.NetData.OnBlackListUpdated := OnNetBlackListUpdated;
   TNetData.NetData.OnNodeServersUpdated := OnNetNodeServersUpdated;
+}
 end;
 
 destructor TFrameNodeStats.Destroy;

src/gui-classic/UFRMWallet.pas

@@ -634,8 +634,9 @@ procedure TFRMWallet.FinishedLoadingApp;
   // Init
   TNetData.NetData.OnReceivedHelloMessage := OnReceivedHelloMessage;
   TNetData.NetData.OnStatisticsChanged := OnNetStatisticsChanged;
-//  TNetData.NetData.OnNodeServersUpdated := OnNetNodeServersUpdated; // try to move to FrameNodeStats
-//  TNetData.NetData.OnBlackListUpdated := OnNetBlackListUpdated;  // try to move to FrameNodeStats
+  TNetData.NetData.OnNetConnectionsUpdated := FrameNodeStats.OnNetConnectionsUpdated;
+  TNetData.NetData.OnNodeServersUpdated := FrameNodeStats.OnNetNodeServersUpdated;
+  TNetData.NetData.OnBlackListUpdated := FrameNodeStats.OnNetBlackListUpdated;
 
   //
   TimerUpdateStatus.Interval := 1000;