From 345ec0337e21285538a494ba5f32bc5681bf49a4 Mon Sep 17 00:00:00 2001 From: Alonso Mondal Date: Mon, 9 Feb 2026 16:11:52 -0600 Subject: [PATCH] updating github api called in PF Editor for checking updates --- .../PlayFabEditorExtensions/Editor/PlayFabEditor.cs | 2 +- .../Editor/Scripts/Panels/PlayFabEditorSDKTools.cs | 2 +- .../Scripts/PlayFabEditorSDK/PlayFabEditorHttp.cs | 13 +++++-------- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/PlayFabEditor.cs b/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/PlayFabEditor.cs index 5907ea5a4..87d734fbb 100644 --- a/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/PlayFabEditor.cs +++ b/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/PlayFabEditor.cs @@ -361,7 +361,7 @@ private static void GetLatestEdExVersion() if (DateTime.Today > threshold) { - PlayFabEditorHttp.MakeGitHubApiCall("https://api.github.com/repos/PlayFab/UnitySDK/git/refs/tags", (version) => + PlayFabEditorHttp.MakeGitHubApiCall("https://api.github.com/repos/PlayFab/UnitySDK/releases/latest", (version) => { latestEdExVersion = version ?? "Unknown"; PlayFabEditorPrefsSO.Instance.EdSet_latestEdExVersion = latestEdExVersion; diff --git a/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/Scripts/Panels/PlayFabEditorSDKTools.cs b/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/Scripts/Panels/PlayFabEditorSDKTools.cs index 8355553b3..2dfec12d3 100644 --- a/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/Scripts/Panels/PlayFabEditorSDKTools.cs +++ b/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/Scripts/Panels/PlayFabEditorSDKTools.cs @@ -529,7 +529,7 @@ private static void GetLatestSdkVersion() if (DateTime.Today > threshold) { - PlayFabEditorHttp.MakeGitHubApiCall("https://api.github.com/repos/PlayFab/UnitySDK/git/refs/tags", (version) => + PlayFabEditorHttp.MakeGitHubApiCall("https://api.github.com/repos/PlayFab/UnitySDK/releases/latest", (version) => { latestSdkVersion = version ?? "Unknown"; PlayFabEditorPrefsSO.Instance.EdSet_latestSdkVersion = latestSdkVersion; diff --git a/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/Scripts/PlayFabEditorSDK/PlayFabEditorHttp.cs b/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/Scripts/PlayFabEditorSDK/PlayFabEditorHttp.cs index f874676f0..c65ec06ce 100644 --- a/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/Scripts/PlayFabEditorSDK/PlayFabEditorHttp.cs +++ b/targets/unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/Scripts/PlayFabEditorSDK/PlayFabEditorHttp.cs @@ -60,18 +60,15 @@ private static void OnGitHubSuccess(Action resultCallback, string respon if (resultCallback == null) return; - var jsonResponse = JsonWrapper.DeserializeObject>(response); - if (jsonResponse == null || jsonResponse.Count == 0) + var jsonResponse = JsonWrapper.DeserializeObject(response); + if (jsonResponse == null) return; - // list seems to come back in ascending order (oldest -> newest) - var latestSdkTag = (JsonObject)jsonResponse[jsonResponse.Count - 1]; + // The /releases/latest endpoint returns a single object with a "tag_name" field object tag; - if (latestSdkTag.TryGetValue("ref", out tag)) + if (jsonResponse.TryGetValue("tag_name", out tag) && tag != null) { - var startIndex = tag.ToString().LastIndexOf('/') + 1; - var length = tag.ToString().Length - startIndex; - resultCallback(tag.ToString().Substring(startIndex, length)); + resultCallback(tag.ToString()); } else {