Skip to content

Capture raw, unfiltered data by default in p1_capture. #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamshapiro0 merged 2 commits into from
Dec 18, 2024
Merged

Capture raw, unfiltered data by default in p1_capture. #349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
204a53d
Fixed p1_capture --output-format option.
adamshapiro0 Dec 9, 2024
29a4f38
Output raw format by default, don't filter out any binary data.
adamshapiro0 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions python/fusion_engine_client/applications/p1_capture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def main():

file_group = parser.add_argument_group('File Capture')
file_group.add_argument(
'-f', '--output-format', default='p1log', choices=('p1log', 'raw', 'csv'),
'-f', '--output-format', default='raw', choices=('p1log', 'raw', 'csv'),
help="""\
The format of the file to be generated when --output is enabled:
- p1log - Create a *.p1log file containing only FusionEngine messages (default)
Expand Down Expand Up @@ -142,7 +142,7 @@ def main():

# Open the output file if logging was requested.
if options.output is not None:
if options.format == 'p1log':
if options.output_format == 'p1log':
p1i_path = os.path.splitext(options.output)[0] + '.p1i'
if os.path.exists(p1i_path):
os.remove(p1i_path)
Expand All @@ -151,9 +151,9 @@ def main():
else:
output_file = None

generating_raw_log = (output_file is not None and options.format == 'raw')
generating_p1log = (output_file is not None and options.format == 'p1log')
generating_csv = (output_file is not None and options.format == 'csv')
generating_raw_log = (output_file is not None and options.output_format == 'raw')
generating_p1log = (output_file is not None and options.output_format == 'p1log')
generating_csv = (output_file is not None and options.output_format == 'csv')

if generating_csv:
output_file.write(b'host_time,type,p1_time,sys_time\n')
Expand Down
Loading