-
Notifications
You must be signed in to change notification settings - Fork 26
Re-enable Python 3.13 smoke tests after downstream packages are updated #381
Copy link
Copy link
Open
Description
Context
PR #365 adds Python 3.13 support to policyengine-core. To resolve a circular dependency issue (also encountered in PR #338), we had to temporarily skip the smoke tests for Python 3.13 that install policyengine-us from PyPI.
The Circular Dependency
- policyengine-core needs to support Python 3.13 first
- policyengine-us (and other country packages) can't be updated until policyengine-core supports Python 3.13
- But CI fails because the smoke tests try to install policyengine-us which doesn't support Python 3.13 yet
Current Workaround
In PR #365, we modified to skip policyengine-us installation and smoke tests specifically for Python 3.13:
- name: Install -us package from PyPI
# Skip policyengine-us installation for Python 3.13 until it's updated
if: matrix.python-version \!= '3.13'
run: python -m pip install policyengine-us
- name: Run smoke tests only
# Only run smoke tests if policyengine-us was installed
if: matrix.python-version \!= '3.13'
run: pytest -m smokeTasks
After PR #365 is merged and released:
- Update policyengine-us to support Python 3.13
- Update policyengine-uk to support Python 3.13
- Update policyengine-canada to support Python 3.13
- Update other country packages to support Python 3.13
- Remove the Python 3.13 skip conditions from the smoke tests in
- Verify all smoke tests pass with Python 3.13
Related PRs
- Upgrade Python to 3.13 #365 - Initial Python 3.13 support
- Upgrade to Python 3.13 #338 - Earlier attempt that encountered the same issue
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels