Skip to content
This repository was archived by the owner on Nov 10, 2022. It is now read-only.
This repository was archived by the owner on Nov 10, 2022. It is now read-only.

Cleanup passes Typescript and Travis are incompatible #71

@TimvdLippe

Description

@TimvdLippe

The Travis pass overrides the install script (

// Override install script for all elements
const install =
[`npm install -g ${tools.join(' ')}`, 'polymer install --variants'];
if (!Array.isArray(travis.install) || !arraysEqual(travis.install, install)) {
travis.install = install;
}
), but the TypeScript pass actually introduces npm dependencies to be able to generate the TypeScript definitions.

To this end, when you run both Travis and TypeScript, the command npm install (which is the default Travis install command) is no longer run, thus the npm dependencies for gen-typescript-declarations are no longer installed.

Instead, the current commands in install should be moved to the first lines of before_script, such that install once again runs npm install on Travis.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions